Improve Provider Logging (#2801)

* Improve test logging

* Fix logging in TF provider

* fix

* fix lint

Author: mgyucht

internal/acceptance/init_test.go

@@ -20,6 +20,7 @@ import (
 	"github.com/databricks/databricks-sdk-go/logger"
 	"github.com/databricks/terraform-provider-databricks/commands"
 	"github.com/databricks/terraform-provider-databricks/common"
+	dbproviderlogger "github.com/databricks/terraform-provider-databricks/logger"
 	"github.com/databricks/terraform-provider-databricks/provider"
 	"github.com/databricks/terraform-provider-databricks/qa"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
@@ -30,12 +31,8 @@ import (
 func init() {
 	rand.Seed(time.Now().UnixMicro())
 	databricks.WithProduct("tf-integration-tests", common.Version())
-	if isInDebug() {
-		// Terraform SDK v2 intercepts default logger
-		// that Go SDK SimpleLogger is using, so we have
-		// to re-implement one again.
-		logger.DefaultLogger = stdErrLogger{}
-	}
+	os.Setenv("TF_LOG", "DEBUG")
+	dbproviderlogger.SetLogger()
 }
 
 func workspaceLevel(t *testing.T, steps ...step) {
@@ -180,8 +177,8 @@ func run(t *testing.T, steps []step) {
 	ts := []resource.TestStep{}
 	ctx := context.Background()
 
-	stepConfig := ""
 	for i, s := range steps {
+		stepConfig := ""
 		if s.Template != "" {
 			stepConfig = environmentTemplate(t, s.Template, vars)
 		}
@@ -381,33 +378,3 @@ func loadDebugEnvIfRunsFromIDE(t *testing.T, key string) {
 		os.Setenv(k, v)
 	}
 }
-
-type stdErrLogger struct {
-	traceEnabled bool
-}
-
-func (l stdErrLogger) Enabled(_ context.Context, level logger.Level) bool {
-	return true
-}
-
-func (l stdErrLogger) Tracef(_ context.Context, format string, v ...interface{}) {
-	if l.traceEnabled {
-		fmt.Fprintf(os.Stderr, "[TRACE] "+format+"\n", v...)
-	}
-}
-
-func (l stdErrLogger) Debugf(_ context.Context, format string, v ...interface{}) {
-	fmt.Fprintf(os.Stderr, "\n[DEBUG] "+format+"\n", v...)
-}
-
-func (l stdErrLogger) Infof(_ context.Context, format string, v ...interface{}) {
-	fmt.Fprintf(os.Stderr, "\n[INFO] "+format+"\n", v...)
-}
-
-func (l stdErrLogger) Warnf(_ context.Context, format string, v ...interface{}) {
-	fmt.Fprintf(os.Stderr, "\n[WARN] "+format+"\n", v...)
-}
-
-func (l stdErrLogger) Errorf(_ context.Context, format string, v ...interface{}) {
-	fmt.Fprintf(os.Stderr, "[ERROR] "+format+"\n", v...)
-}

logger/logger.go

@@ -61,5 +61,6 @@ func (tfLogger *TfLogger) Errorf(ctx context.Context, format string, v ...any) {
 }
 
 func SetLogger() {
-	logger.DefaultLogger = &TfLogger{}
+	var tfLogger *TfLogger
+	logger.DefaultLogger = tfLogger
 }