Migrate databricks_views data source to Go SDK (#2073)

Author: nkvuong

catalog/data_views.go

@@ -3,26 +3,26 @@ package catalog
 import (
 	"context"
 
+	"github.com/databricks/databricks-sdk-go"
+	"github.com/databricks/databricks-sdk-go/service/unitycatalog"
 	"github.com/databricks/terraform-provider-databricks/common"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
 )
 
 func DataSourceViews() *schema.Resource {
-	type viewsData struct {
+	return common.WorkspaceData(func(ctx context.Context, data *struct {
 		CatalogName string   `json:"catalog_name"`
 		SchemaName  string   `json:"schema_name"`
 		Ids         []string `json:"ids,omitempty" tf:"computed,slice_set"`
-	}
-	return common.DataResource(viewsData{}, func(ctx context.Context, e any, c *common.DatabricksClient) error {
-		data := e.(*viewsData)
-		tablesAPI := NewTablesAPI(ctx, c)
-		tables, err := tablesAPI.listTables(data.CatalogName, data.SchemaName)
+	}, w *databricks.WorkspaceClient) error {
+
+		tables, err := w.Tables.ListAll(ctx, unitycatalog.ListTablesRequest{CatalogName: data.CatalogName, SchemaName: data.SchemaName})
 		if err != nil {
 			return err
 		}
-		for _, v := range tables.Tables {
+		for _, v := range tables {
 			if v.TableType == "VIEW" {
-				data.Ids = append(data.Ids, v.FullName())
+				data.Ids = append(data.Ids, v.FullName)
 			}
 		}
 		return nil

catalog/data_views_test.go

@@ -3,6 +3,7 @@ package catalog
 import (
 	"testing"
 
+	"github.com/databricks/databricks-sdk-go/service/unitycatalog"
 	"github.com/databricks/terraform-provider-databricks/qa"
 )
 
@@ -11,19 +12,21 @@ func TestViewsData(t *testing.T) {
 		Fixtures: []qa.HTTPFixture{
 			{
 				Method:   "GET",
-				Resource: "/api/2.1/unity-catalog/tables/?catalog_name=a&schema_name=b",
-				Response: Tables{
-					Tables: []TableInfo{
+				Resource: "/api/2.1/unity-catalog/tables?catalog_name=a&schema_name=b",
+				Response: unitycatalog.ListTablesResponse{
+					Tables: []unitycatalog.TableInfo{
 						{
 							CatalogName: "a",
 							SchemaName:  "b",
 							Name:        "c",
+							FullName:    "a.b.c",
 							TableType:   "MANAGED",
 						},
 						{
 							CatalogName: "a",
 							SchemaName:  "b",
 							Name:        "d",
+							FullName:    "a.b.d",
 							TableType:   "VIEW",
 						},
 					},