Fixes #602 - Use https://staticcheck.io/ for linting

* previous solution, golangci-lint, does no longer seem to be actively maintained
* staticcheck is natively integrated with VSCode IDE
* it's easier to have one common and modern linting framework

Author: nfx

.devcontainer/Dockerfile

@@ -52,7 +52,7 @@ RUN \
     && go get gotest.tools/gotestsum \
     # --> Go symbols and outline for go to symbol support and test support 
     && go get github.com/acroca/[email protected] && go get github.com/ramya-rao-a/go-outline@7182a932836a71948db4a81991a494751eccfe77 \
-    # --> GolangCI-lint
-    && go get github.com/golangci/golangci-lint/cmd/[email protected] \
+    # --> Static checker
+    && go install honnef.co/go/tools/cmd/staticcheck@latest \
 
 USER developer

.github/workflows/push.yml

@@ -37,7 +37,7 @@ jobs:
           echo "GOPATH=$(go env GOPATH)" >> $GITHUB_ENV
           echo "$(go env GOPATH)/bin" >> $GITHUB_PATH
           go get gotest.tools/gotestsum
-          go get github.com/golangci/golangci-lint/cmd/[email protected]
+          go install honnef.co/go/tools/cmd/staticcheck@latest
 
       - name: Pull external libraries
         run: make vendor

.github/workflows/release.yml

@@ -20,11 +20,12 @@ jobs:
         uses: actions/setup-go@v1
         with:
           go-version: 1.13.x
-      - name: Download gotestsum and golangci
+      - name: Download gotestsum and staticcheck
         run: |
-          # Install
-          curl -sSL "https://github.com/gotestyourself/gotestsum/releases/download/v0.4.2/gotestsum_0.4.2_linux_amd64.tar.gz" | sudo tar -xz -C /usr/local/bin gotestsum
-          curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.25.0
+          echo "GOPATH=$(go env GOPATH)" >> $GITHUB_ENV
+          echo "$(go env GOPATH)/bin" >> $GITHUB_PATH
+          go get gotest.tools/gotestsum
+          go install honnef.co/go/tools/cmd/staticcheck@latest
       - name: Import GPG key
         id: import_gpg
         uses: crazy-max/ghaction-import-gpg@v2

.golangci.yml

@@ -1,8 +1,5 @@
-# This is an example goreleaser.yaml file with some sane defaults.
-# Make sure to check the documentation at http://goreleaser.com
 before:
   hooks:
-    # You may remove this if you don't use go modules.
     - go mod download
 builds:
 - env:

.goreleaser.yml

@@ -41,17 +41,16 @@ Most likely, `terraform init -upgrade -verify-plugins=false -lock=false` would b
 
 ## Developing provider
 
-After installing necessary software for building provider from sources, you should install `golangci-lint` and `gotestsum` in order to run `make test`.
+After installing necessary software for building provider from sources, you should install `staticcheck` and `gotestsum` in order to run `make test`.
 
 Make sure you have `$GOPATH/bin` in your `$PATH`:
 ```
 echo "export PATH=\$PATH:$(go env GOPATH)/bin" >> ~/.bash_profile
 ```
 
-Installing `golangci-lint`:
+Installing `staticcheck`:
 ```bash
-curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.27.0
-$(go env GOPATH)/bin/golangci-lint
+go install honnef.co/go/tools/cmd/staticcheck@latest
 ```
 
 Installing `gotestsum`:
@@ -298,7 +297,7 @@ func TestPreviewAccPipelineResource_CreatePipeline(t *testing.T) {
 
 ## Linting
 
-Please use makefile for linting. If you run `golangci-lint` by itself it will fail due to different tags containing same functions. 
+Please use makefile for linting. If you run `staticcheck` by itself it will fail due to different tags containing same functions. 
 So please run `make lint` instead.
 
 ## Unit testing resources

CONTRIBUTING.md

@@ -7,8 +7,8 @@ fmt:
 	@gofmt -w $(shell find . -type f -name '*.go' -not -path "./vendor/*")
 
 lint: vendor
-	@echo "✓ Linting source code with golangci-lint make sure you run make fmt ..."
-	@golangci-lint run --skip-dirs-use-default --timeout 5m
+	@echo "✓ Linting source code with https://staticcheck.io/ ..."
+	@staticcheck ./...
 
 test: lint
 	@echo "✓ Running tests ..."

Makefile

@@ -140,7 +140,7 @@ func (a PermissionsAPI) put(objectID string, objectACL AccessControlChangeList)
 
 // Update updates object permissions. Technically, it's using method named SetOrDelete, but here we do more
 func (a PermissionsAPI) Update(objectID string, objectACL AccessControlChangeList) error {
-	if "/authorization/tokens" == objectID {
+	if objectID == "/authorization/tokens" {
 		// Cannot remove admins's CAN_MANAGE permission on tokens
 		objectACL.AccessControlList = append(objectACL.AccessControlList, AccessControlChange{
 			GroupName:       "admins",
@@ -279,7 +279,7 @@ func (oa *ObjectACL) ToPermissionsEntity(ctx context.Context, d *schema.Resource
 		}
 		return entity, nil
 	}
-	return entity, fmt.Errorf("Unknown object type %s", oa.ObjectType)
+	return entity, fmt.Errorf("unknown object type %s", oa.ObjectType)
 }
 
 // ResourcePermissions definition
@@ -304,7 +304,7 @@ func ResourcePermissions() *schema.Resource {
 			"access_control", "group_name"); err == nil {
 			groupNameSchema.ValidateDiagFunc = func(i interface{}, p cty.Path) diag.Diagnostics {
 				if v, ok := i.(string); ok {
-					if "admins" == strings.ToLower(v) {
+					if strings.ToLower(v) == "admins" {
 						return diag.Diagnostics{
 							{
 								Summary:       "It is not possible to restrict any permissions from `admins`.",

access/resource_permissions.go

@@ -319,7 +319,7 @@ func TestResourcePermissionsCreate_no_access_control(t *testing.T) {
 		State: map[string]interface{}{
 			"cluster_id": "abc",
 		},
-	}.ExpectError(t, "Invalid config supplied. [access_control] Missing required argument")
+	}.ExpectError(t, "invalid config supplied. [access_control] Missing required argument")
 }
 
 func TestResourcePermissionsCreate_conflicting_fields(t *testing.T) {
@@ -338,7 +338,7 @@ func TestResourcePermissionsCreate_conflicting_fields(t *testing.T) {
 			},
 		},
 	}.Apply(t)
-	qa.AssertErrorStartsWith(t, err, "Invalid config supplied. cluster_id: conflicts with notebook_path. notebook_path: conflicts with cluster_id")
+	qa.AssertErrorStartsWith(t, err, "invalid config supplied. cluster_id: conflicts with notebook_path. notebook_path: conflicts with cluster_id")
 }
 
 func TestResourcePermissionsCreate_AdminsThrowError(t *testing.T) {
@@ -354,7 +354,7 @@ func TestResourcePermissionsCreate_AdminsThrowError(t *testing.T) {
 		}
 		`,
 	}.Apply(t)
-	assert.EqualError(t, err, "Invalid config supplied. [access_control] "+
+	assert.EqualError(t, err, "invalid config supplied. [access_control] "+
 		"It is not possible to restrict any permissions from `admins`.")
 }
 
@@ -716,7 +716,7 @@ func TestResourcePermissionsUpdate(t *testing.T) {
 func permissionsTestHelper(t *testing.T,
 	cb func(permissionsAPI PermissionsAPI, user, group string,
 		ef func(string) PermissionsEntity)) {
-	if "" == os.Getenv("CLOUD_ENV") {
+	if os.Getenv("CLOUD_ENV") == "" {
 		t.Skip("Acceptance tests skipped unless env 'CLOUD_ENV' is set")
 	}
 	randomName := acctest.RandStringFromCharSet(10, acctest.CharSetAlphaNum)

access/resource_permissions_test.go

@@ -63,9 +63,11 @@ func (a SecretScopesAPI) Create(s SecretScope) error {
 			return err
 		}
 		if !a.client.IsAzure() {
+			//lint:ignore ST1005 Azure is a valid capitalized string
 			return fmt.Errorf("Azure KeyVault is not available")
 		}
 		if a.client.AzureAuth.IsClientSecretSet() {
+			//lint:ignore ST1005 Azure is a valid capitalized string
 			return fmt.Errorf("Azure KeyVault cannot yet be configured for Service Principal authorization")
 		}
 		req.BackendType = "AZURE_KEYVAULT"