Fixed privilege_assignment in databricks_sql_permissions (#1872)

* remove the backtick before the comparison otherwise the databases are not equal although they are the same

* Add acc test for Database ACL with and without backtick in databases names

Co-authored-by: Serge Smertin <[email protected]>

Author: TheoPth

access/resource_sql_permissions.go

@@ -148,9 +148,12 @@ func (ta *SqlPermissions) read() error {
 		if !strings.EqualFold(currentType, thisType) {
 			continue
 		}
-		if !strings.EqualFold(currentKey, thisKey) {
+
+		noBackticks := strings.ReplaceAll(thisKey, "`", "")
+		if !strings.EqualFold(currentKey, thisKey) && !strings.EqualFold(currentKey, noBackticks) {
 			continue
 		}
+
 		if strings.HasPrefix(currentAction, "DENIED_") {
 			// DENY statements are intentionally not supported.
 			continue

access/resource_sql_permissions_test.go

@@ -89,6 +89,22 @@ func TestTableACLGrants(t *testing.T) {
 	assert.Len(t, ta.PrivilegeAssignments[0].Privileges, 2)
 }
 
+func TestDatabaseACLGrants(t *testing.T) {
+	ta := SqlPermissions{ Database: "default",
+	exec: mockData{
+		"SHOW GRANT ON DATABASE `default`": {
+			// principal, actionType, objType, objectKey
+			// Test with and without backticks
+			{"users", "SELECT", "database", "default"},
+			{"users", "USAGE", "database", "`default`"},
+		},
+	}}
+	err := ta.read()
+	assert.NoError(t, err)
+	assert.Len(t, ta.PrivilegeAssignments, 1)
+	assert.Len(t, ta.PrivilegeAssignments[0].Privileges, 2)
+}
+
 type failedCommand string
 
 func (fc failedCommand) Execute(clusterID, language, commandStr string) common.CommandResults {