Skip to content

Commit d7aba5c

Browse files
pieternnfx
authored andcommitted
Return earlier
1 parent 4caedb3 commit d7aba5c

File tree

3 files changed

+3
-15
lines changed

3 files changed

+3
-15
lines changed

sqlanalytics/resource_query.go

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -343,11 +343,7 @@ func (q *QueryEntity) fromAPIObject(aq *api.Query, schema map[string]*schema.Sch
343343
}
344344

345345
// Transform to ResourceData.
346-
if err := common.StructToData(*q, schema, data); err != nil {
347-
return err
348-
}
349-
350-
return nil
346+
return common.StructToData(*q, schema, data)
351347
}
352348

353349
// NewQueryAPI ...

sqlanalytics/resource_visualization.go

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -52,11 +52,7 @@ func (v *VisualizationEntity) fromAPIObject(av *api.Visualization, schema map[st
5252
v.Options = string(av.Options)
5353

5454
// Transform to ResourceData.
55-
if err := common.StructToData(*v, schema, data); err != nil {
56-
return err
57-
}
58-
59-
return nil
55+
return common.StructToData(*v, schema, data)
6056
}
6157

6258
// NewVisualizationAPI ...

sqlanalytics/resource_widget.go

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -182,11 +182,7 @@ func (w *WidgetEntity) fromAPIObject(aw *api.Widget, schema map[string]*schema.S
182182
sort.Sort(sortWidgetParameter(w.Parameter))
183183

184184
// Pass to ResourceData.
185-
if err := common.StructToData(*w, schema, data); err != nil {
186-
return err
187-
}
188-
189-
return nil
185+
return common.StructToData(*w, schema, data)
190186
}
191187

192188
// NewWidgetAPI ...

0 commit comments

Comments
 (0)