Change default for delta_sharing_recipient_token_lifetime_in_seconds from 0 to 31536000 (1 year)

Author: 840

catalog/resource_metastore.go

@@ -70,6 +70,7 @@ func ResourceMetastore() common.Resource {
 			// Field dependencies and validation
 			m["delta_sharing_scope"].RequiredWith = []string{"delta_sharing_recipient_token_lifetime_in_seconds"}
 			m["delta_sharing_recipient_token_lifetime_in_seconds"].RequiredWith = []string{"delta_sharing_scope"}
+			m["delta_sharing_recipient_token_lifetime_in_seconds"].Default = 31536000 // 1 year
 			common.CustomizeSchemaPath(m, "delta_sharing_scope").SetValidateFunc(
 				validation.StringInSlice([]string{"INTERNAL", "INTERNAL_AND_EXTERNAL"}, false),
 			)

docs/resources/metastore.md

@@ -75,7 +75,7 @@ The following arguments are required:
 * `region` - (Mandatory for account-level) The region of the metastore
 * `owner` - (Optional) Username/groupname/sp application_id of the metastore owner.
 * `delta_sharing_scope` - (Optional) Required along with `delta_sharing_recipient_token_lifetime_in_seconds`. Used to enable delta sharing on the metastore. Valid values: `INTERNAL`, `INTERNAL_AND_EXTERNAL`.  `INTERNAL` only allows sharing within the same account, and `INTERNAL_AND_EXTERNAL` allows cross account sharing and token based sharing.
-* `delta_sharing_recipient_token_lifetime_in_seconds` - (Optional) Required along with `delta_sharing_scope`. Used to set expiration duration in seconds on recipient data access tokens. Set to 0 for unlimited duration.
+* `delta_sharing_recipient_token_lifetime_in_seconds` - (Optional) Required along with `delta_sharing_scope`. Used to set expiration duration in seconds on recipient data access tokens.
 * `delta_sharing_organization_name` - (Optional) The organization name of a Delta Sharing entity. This field is used for Databricks to Databricks sharing. Once this is set it cannot be removed and can only be modified to another valid value. To delete this value please taint and recreate the resource.
 * `external_access_enabled` - (Optional) Whether to allow non-DBR clients to directly access entities under the metastore.
 * `force_destroy` - (Optional) Destroy metastore regardless of its contents.