Skip to content

Commit e01993d

Browse files
committed
Fix #868 - add hostname to odbc_params
1 parent 7194c39 commit e01993d

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

docs/resources/sql_endpoint.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ The following arguments are supported:
4545
In addition to all arguments above, the following attributes are exported:
4646

4747
* `jdbc_url` - JDBC connection string.
48-
* `odbc_params` - ODBC connection params: `odbc_params.host`, `odbc_params.path`, `odbc_params.protocol`, and `odbc_params.port`.
48+
* `odbc_params` - ODBC connection params: `odbc_params.hostname`, `odbc_params.path`, `odbc_params.protocol`, and `odbc_params.port`.
4949
* `data_source_id` - ID of the data source for this endpoint. This is used to bind an SQLA query to an endpoint.
5050

5151
## Access Control

sqlanalytics/resource_sql_endpoint.go

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,12 +43,16 @@ type SQLEndpoint struct {
4343
DataSourceID string `json:"data_source_id,omitempty" tf:"computed"`
4444
}
4545

46-
// OdbcParams ...
46+
// OdbcParams hold information required to submit SQL commands to the SQL endpoint using ODBC.
4747
type OdbcParams struct {
48-
Host string `json:"host"`
48+
Hostname string `json:"hostname,omitempty"`
4949
Path string `json:"path"`
5050
Protocol string `json:"protocol"`
5151
Port int32 `json:"port"`
52+
53+
// TODO: eventually remove this column,
54+
// as it doesn't seem to be populated
55+
Host string `json:"host,omitempty"`
5256
}
5357

5458
// Tags ...

0 commit comments

Comments
 (0)