Skip to content

Commit f3f3ec2

Browse files
authored
Add test to ensure deterministic coverage on widget parameter sorter (#1093)
1 parent 1c6ce96 commit f3f3ec2

File tree

1 file changed

+16
-0
lines changed

1 file changed

+16
-0
lines changed

sql/resource_widget_test.go

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ package sql
22

33
import (
44
"encoding/json"
5+
"sort"
56
"testing"
67

78
"github.com/databrickslabs/terraform-provider-databricks/qa"
@@ -648,3 +649,18 @@ func TestWidgetDelete(t *testing.T) {
648649
func TestResourceWidgetCornerCases(t *testing.T) {
649650
qa.ResourceCornerCases(t, ResourceWidget(), qa.CornerCaseID("foo/bar"))
650651
}
652+
653+
func TestWidgetParameterSorter(t *testing.T) {
654+
wp := sortWidgetParameter{
655+
WidgetParameter{Name: "foo"},
656+
WidgetParameter{Name: "bar"},
657+
}
658+
659+
// Widget parameters should be sorted by their name to maintain deterministic ordering.
660+
// Since they are not ordered in the API payload, not ordering them means users would
661+
// see false state mismatches on comparison.
662+
sort.Sort(wp)
663+
664+
assert.Equal(t, "bar", wp[0].Name)
665+
assert.Equal(t, "foo", wp[1].Name)
666+
}

0 commit comments

Comments
 (0)