Add integration test coverage for delta sharing parameters (#2991)

Author: mgyucht

internal/acceptance/metastore_test.go

@@ -1,73 +1,90 @@
 package acceptance
 
 import (
+	"encoding/json"
+	"fmt"
 	"os"
+	"strings"
 	"testing"
+
+	"github.com/stretchr/testify/require"
 )
 
-func TestUcAccMetastore(t *testing.T) {
-	cloudEnv := os.Getenv("CLOUD_ENV")
+func getStorageRoot(cloudEnv string) string {
 	switch cloudEnv {
 	case "ucacct":
-		unityAccountLevel(t, step{
-			Template: `resource "databricks_metastore" "this" {
-				name = "{var.RANDOM}"
-				storage_root = "s3://{env.TEST_BUCKET}/test{var.RANDOM}"
-				region = "us-east-1"
-				force_destroy = true
-			}`,
-		})
+		return "s3://{env.TEST_BUCKET}/test{var.RANDOM}"
 	case "azure-ucacct":
-		unityAccountLevel(t, step{
-			Template: `resource "databricks_metastore" "this" {
-				name = "{var.RANDOM}"
-				storage_root = "abfss://{var.RANDOM}@{var.RANDOM}.dfs.core.windows.net/"
-				region = "eastus"
-				force_destroy = true
-			}`,
-		})
+		return "abfss://{var.RANDOM}@{var.RANDOM}/"
 	case "gcp-accounts":
-		unityAccountLevel(t, step{
-			Template: `resource "databricks_metastore" "this" {
-				name = "{var.RANDOM}"
-				storage_root = "gs://{var.RANDOM}/metastore"
-				region = "us-east1"
-				force_destroy = true
-			}`,
-		})
+		return "gs://{var.RANDOM}/metastore"
 	default:
-		t.Skipf("not available on %s", cloudEnv)
+		return ""
 	}
 }
 
-func TestUcAccRootlessMetastore(t *testing.T) {
-	cloudEnv := os.Getenv("CLOUD_ENV")
+func getRegion(cloudEnv string) string {
 	switch cloudEnv {
 	case "ucacct":
-		unityAccountLevel(t, step{
-			Template: `resource "databricks_metastore" "this" {
-				name = "{var.RANDOM}"
-				region = "us-east-1"
-				force_destroy = true
-			}`,
-		})
+		return "us-east-1"
 	case "azure-ucacct":
-		unityAccountLevel(t, step{
-			Template: `resource "databricks_metastore" "this" {
-				name = "{var.RANDOM}"
-				region = "eastus"
-				force_destroy = true
-			}`,
-		})
+		return "eastus"
 	case "gcp-accounts":
-		unityAccountLevel(t, step{
-			Template: `resource "databricks_metastore" "this" {
-				name = "{var.RANDOM}"
-				region = "us-east1"
-				force_destroy = true
-			}`,
-		})
+		return "us-east1"
 	default:
-		t.Skipf("not available on %s", cloudEnv)
+		return ""
+	}
+}
+
+func TestUcAccRootlessMetastore(t *testing.T) {
+	loadDebugEnvIfRunsFromIDE(t, "ucacct")
+	runMetastoreTest(t, map[string]any{
+		"region": getRegion(os.Getenv("CLOUD_ENV")),
+	})
+}
+
+func TestUcAccMetastore(t *testing.T) {
+	loadDebugEnvIfRunsFromIDE(t, "ucacct")
+	runMetastoreTest(t, map[string]any{
+		"storage_root": getStorageRoot(os.Getenv("CLOUD_ENV")),
+		"region":       getRegion(os.Getenv("CLOUD_ENV")),
+	})
+}
+
+func TestUcAccMetastoreDeltaSharing(t *testing.T) {
+	loadDebugEnvIfRunsFromIDE(t, "ucacct")
+	runMetastoreTest(t, map[string]any{
+		"storage_root":        getStorageRoot(os.Getenv("CLOUD_ENV")),
+		"region":              getRegion(os.Getenv("CLOUD_ENV")),
+		"delta_sharing_scope": "INTERNAL",
+		"delta_sharing_recipient_token_lifetime_in_seconds": 3600,
+		"delta_sharing_organization_name":                   "databricks-tf-provider-test",
+	})
+}
+
+func TestUcAccMetastoreDeltaSharingInfiniteLifetime(t *testing.T) {
+	loadDebugEnvIfRunsFromIDE(t, "ucacct")
+	runMetastoreTest(t, map[string]any{
+		"storage_root":        getStorageRoot(os.Getenv("CLOUD_ENV")),
+		"region":              getRegion(os.Getenv("CLOUD_ENV")),
+		"delta_sharing_scope": "INTERNAL",
+		"delta_sharing_recipient_token_lifetime_in_seconds": 0,
+	})
+}
+
+func runMetastoreTest(t *testing.T, extraAttributes map[string]any) {
+	params := make([]string, len(extraAttributes))
+	for k, v := range extraAttributes {
+		jsonValue, err := json.Marshal(v)
+		require.NoError(t, err)
+		params = append(params, k+" = "+string(jsonValue))
 	}
+	template := strings.Join(params, "\n\t\t\t")
+	unityAccountLevel(t, step{
+		Template: fmt.Sprintf(`resource "databricks_metastore" "this" {
+			name = "{var.RANDOM}"
+			force_destroy = true
+			%s
+		}`, template),
+	})
 }