[Exporter] Support exporting of databricks_mws_ncc_binding (#5184)

## Changes
<!-- Summary of your changes that are easy to understand -->

## Tests
<!--
How is this tested? Please see the checklist below and also describe any
other relevant tests
-->

- [x] `make test` run locally
- [x] relevant change in `docs/` folder
- [ ] covered with integration tests in `internal/acceptance`
- [x] using Go SDK
- [ ] using TF Plugin Framework
- [x] has entry in `NEXT_CHANGELOG.md` file

Author: alexott

NEXT_CHANGELOG.md

@@ -16,6 +16,7 @@
 
 ### Exporter
 
+* Support exporting of `databricks_mws_ncc_binding` ([#5184](https://github.com/databricks/terraform-provider-databricks/pull/5184)).
 * Initial support for resources implemented with plugin framework ([#5176](https://github.com/databricks/terraform-provider-databricks/pull/5176)).
 
 ### Internal Changes

docs/guides/experimental-exporter.md

@@ -167,7 +167,7 @@ Services could be specified in combination with predefined aliases (`all` - for
 * `model-serving` - **listing** [databricks_model_serving](../resources/model_serving.md).
 * `mounts` - **listing** works only in combination with `-mounts` command-line option.
 * `mws` - **listing** resources related to deployment of workspaces on AWS and GCP (networks, credentials, workspaces, ...).
-* `nccs` - **listing** [databricks_mws_network_connectivity_config](../resources/mws_network_connectivity_config.md) and [databricks_mws_ncc_private_endpoint_rule](../resources/mws_ncc_private_endpoint_rule.md).  **Note** we can't export [databricks_mws_ncc_binding](../resources/mws_ncc_binding.md) because of the missing API.
+* `nccs` - **listing** [databricks_mws_network_connectivity_config](../resources/mws_network_connectivity_config.md), [databricks_mws_ncc_private_endpoint_rule](../resources/mws_ncc_private_endpoint_rule.md), and [databricks_mws_ncc_binding](../resources/mws_ncc_binding.md).
 * `notebooks` - **listing** [databricks_notebook](../resources/notebook.md).
 * `policies` - **listing** [databricks_cluster_policy](../resources/cluster_policy).
 * `pools` - **listing** [instance pools](../resources/instance_pool.md).
@@ -251,7 +251,7 @@ Exporter aims to generate HCL code for most of the resources within the Databric
 | [databricks_model_serving](../resources/model_serving) | Yes | Yes | Yes | No |
 | [databricks_mws_credentials](../resources/mws_credentials.md) | Yes | Yes | No | Yes |
 | [databricks_mws_customer_managed_keys](../resources/mws_customer_managed_keys.md) | Yes | Yes | No | Yes |
-| [databricks_mws_ncc_binding](../resources/mws_ncc_binding.md) | No | No | No | No |
+| [databricks_mws_ncc_binding](../resources/mws_ncc_binding.md) | Yes | No | No | Yes |
 | [databricks_mws_ncc_private_endpoint_rule](../resources/mws_ncc_private_endpoint_rule.md) | Yes | No | No | Yes |
 | [databricks_mws_network_connectivity_config](../resources/mws_network_connectivity_config.md) | Yes | Yes | No | Yes |
 | [databricks_mws_networks](../resources/mws_networks.md) | Yes | No | No | Yes |

exporter/importables.go

@@ -2822,6 +2822,9 @@ var resourcesMap map[string]importable = map[string]importable{
 	"databricks_mws_network_connectivity_config": {
 		AccountLevel: true,
 		Service:      "nccs",
+		Name: func(ic *importContext, d *schema.ResourceData) string {
+			return d.Get("name").(string)
+		},
 		List: func(ic *importContext) error {
 			updatedSinceMs := ic.getUpdatedSinceMs()
 			it := ic.accountClient.NetworkConnectivity.ListNetworkConnectivityConfigurations(ic.Context,
@@ -2844,7 +2847,6 @@ var resourcesMap map[string]importable = map[string]importable{
 				ic.Emit(&resource{
 					Resource: "databricks_mws_network_connectivity_config",
 					ID:       nc.AccountId + "/" + nc.NetworkConnectivityConfigId,
-					Name:     nc.Name,
 				})
 				if nc.EgressConfig.TargetRules != nil {
 					for _, rule := range nc.EgressConfig.TargetRules.AzurePrivateEndpointRules {
@@ -2878,6 +2880,35 @@ var resourcesMap map[string]importable = map[string]importable{
 				Match: "network_connectivity_config_id"},
 		},
 	},
+	"databricks_mws_ncc_binding": {
+		AccountLevel: true,
+		Service:      "nccs",
+		List: func(ic *importContext) error {
+			workspaces, err := ic.accountClient.Workspaces.List(ic.Context)
+			if err != nil {
+				return err
+			}
+			for _, workspace := range workspaces {
+				if workspace.NetworkConnectivityConfigId != "" {
+					ic.emitNccBindingAndNcc(workspace.WorkspaceId, workspace.NetworkConnectivityConfigId)
+					if !ic.accountClient.Config.IsAzure() {
+						wsIdString := strconv.FormatInt(workspace.WorkspaceId, 10)
+						ic.Emit(&resource{
+							Resource: "databricks_mws_workspaces",
+							ID:       ic.accountClient.Config.AccountID + "/" + wsIdString,
+							Name:     workspace.WorkspaceName + "_" + wsIdString,
+						})
+					}
+				}
+			}
+			return nil
+		},
+		Depends: []reference{
+			{Path: "network_connectivity_config_id", Resource: "databricks_mws_network_connectivity_config",
+				Match: "network_connectivity_config_id"},
+			{Path: "workspace_id", Resource: "databricks_mws_workspaces", Match: "workspace_id"},
+		},
+	},
 	"databricks_mws_credentials": {
 		AccountLevel: true,
 		Service:      "mws",
@@ -3096,6 +3127,7 @@ var resourcesMap map[string]importable = map[string]importable{
 		Service:      "mws",
 		List: func(ic *importContext) error {
 			if ic.accountClient.Config.IsAzure() {
+				// TODO: use listing on Azure just to emit the NCC bindings
 				return nil
 			}
 			workspaces, err := ic.accountClient.Workspaces.List(ic.Context)
@@ -3166,6 +3198,9 @@ var resourcesMap map[string]importable = map[string]importable{
 					ID:       ic.accountClient.Config.AccountID + "/" + workspace.CredentialsID,
 				})
 			}
+			if workspace.NetworkConnectivityConfigID != "" {
+				ic.emitNccBindingAndNcc(workspace.WorkspaceID, workspace.NetworkConnectivityConfigID)
+			}
 			if ic.isServiceEnabled("idfed") {
 				err := emitIdfedAndUsersSpsGroups(ic, workspace.WorkspaceID)
 				if err != nil {

exporter/util.go

@@ -15,6 +15,7 @@ import (
 	"github.com/databricks/terraform-provider-databricks/aws"
 	"github.com/databricks/terraform-provider-databricks/clusters"
 	"github.com/databricks/terraform-provider-databricks/common"
+	"github.com/databricks/terraform-provider-databricks/mws"
 	"github.com/databricks/terraform-provider-databricks/storage"
 	"golang.org/x/exp/maps"
 
@@ -567,3 +568,22 @@ func makeNameOrIdFunc(nm string) func(ic *importContext, d *schema.ResourceData)
 		return name
 	}
 }
+
+func (ic *importContext) emitNccBindingAndNcc(workspaceId int64, nccId string) {
+	id := fmt.Sprintf("%d/%s", workspaceId, nccId)
+	data := mws.ResourceMwsNccBinding().ToResource().TestResourceData()
+	data.MarkNewResource()
+	data.SetId(id)
+	data.Set("workspace_id", workspaceId)
+	data.Set("network_connectivity_config_id", nccId)
+	ic.Emit(&resource{
+		Resource: "databricks_mws_ncc_binding",
+		Data:     data,
+		ID:       id,
+		Name:     fmt.Sprintf("ws_%d_%s", workspaceId, nccId),
+	})
+	ic.Emit(&resource{
+		Resource: "databricks_mws_network_connectivity_config",
+		ID:       ic.accountClient.Config.AccountID + "/" + nccId,
+	})
+}

mws/resource_mws_workspaces.go

@@ -108,6 +108,7 @@ type Workspace struct {
 	CustomTags                          map[string]string        `json:"custom_tags,omitempty"` // Optional for AWS, not allowed for GCP
 	ComputeMode                         string                   `json:"compute_mode,omitempty" tf:"force_new"`
 	EffectiveComputeMode                string                   `json:"effective_compute_mode" tf:"computed"`
+	NetworkConnectivityConfigID         string                   `json:"network_connectivity_config_id,omitempty" tf:"computed"`
 }
 
 // this type alias hack is required for Marshaller to work without an infinite loop