[Feature] Add unified provider support for manual plugin framework resources and data sources #5127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
tanmay-db
requested review from
Divyansh-db
and removed request for
a team and
Divyansh-db
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
mgyucht
reviewed
Oct 21, 2025
| var name types.String | ||
| resp.Diagnostics.Append(req.Config.GetAttribute(ctx, path.Root("name"), &name)...) | ||
| var workspaceID string | ||
| if !config.ProviderConfig.IsNull() { |
Contributor
There was a problem hiding this comment.
Ditto, let's refactor this out to a separate method
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds unified provider support for manual plugin framework resources and data sources by enabling the provider_config attribute. This allows resources and data sources to specify workspace-level configuration when the provider is configured at the account level.
Key changes:
- Added
GetWorkspaceIDResourceandGetWorkspaceIDDataSourcehelper functions to extract workspace IDs from provider configuration - Added workspace ID validation using regex to ensure it contains only digits
- Updated multiple data sources and the app resource to support the
provider_configattribute with workspace ID extraction
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/providers/pluginfw/tfschema/unified_provider.go | Added helper functions and validation for workspace ID extraction from provider config |
| internal/providers/pluginfw/tfschema/unified_provider_test.go | Added comprehensive unit tests for workspace ID extraction functions |
| internal/providers/pluginfw/products//data_.go | Updated data sources to support provider_config attribute and use unified provider client |
| internal/providers/pluginfw/products/app/resource_app.go | Updated app resource to support provider_config attribute |
| internal/providers/pluginfw/products/app/data_app*.go | Updated app data sources to support provider_config attribute |
| internal/providers/pluginfw/products/sharing/data_shares_acc_test.go | Added acceptance tests for provider_config validation |
| common/client.go | Refactored client methods to support both diagnostics and error return types |
| NEXT_CHANGELOG.md | Documented the new feature |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
41
to
42
| attrs["workspace_id"] = attrs["workspace_id"].(StringAttributeBuilder).AddValidator( | ||
| stringvalidator.RegexMatches(regexp.MustCompile(`^\d+$`), "workspace_id must be a valid integer")) |
There was a problem hiding this comment.
The regex pattern is compiled on every call to ApplySchemaCustomizations. Consider defining the compiled regex as a package-level variable to avoid repeated compilation overhead.
Comment on lines
92
to
93
| attrs["workspace_id"] = attrs["workspace_id"].(StringAttributeBuilder).AddValidator( | ||
| stringvalidator.RegexMatches(regexp.MustCompile(`^\d+$`), "workspace_id must be a valid integer")) |
There was a problem hiding this comment.
The regex pattern is compiled on every call to ApplySchemaCustomizations. Consider defining the compiled regex as a package-level variable to avoid repeated compilation overhead (same issue as in ProviderConfig).
| ), | ||
| } | ||
| return 0, fmt.Errorf("failed to parse workspace_id, please check if the workspace_id in provider_config is a valid integer: %w", err) | ||
|
|
There was a problem hiding this comment.
[nitpick] Remove the blank line before the closing brace to maintain consistent formatting.
Suggested change
mgyucht
approved these changes
Oct 23, 2025
Contributor
mgyucht
left a comment
mgyucht
left a comment
There was a problem hiding this comment.
One question, otherwise LGTM!
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
deco-sdk-tagging bot
added a commit
that referenced
this pull request
Oct 30, 2025
## Release v1.96.0 ### New Features and Improvements * Add `provider_config` support for manual plugin framework resources and data sources([#5127](#5127)) * Added support for custom instance profiles on instance pools on AWS ([#5144](#5144)) * Add `feature_engineering_materialized_feature` resource and data sources([#5166](#5166)) ### Bug Fixes * Remove unnecessary `SetSuppressDiff()` for `workload_size` in `databricks_model_serving` ([#5152](#5152)). ### Documentation * Fix missing GCP IAM permissions for workspace creation in GCP guides ([#5123](#5123)). ### Internal Changes * Caching group membership in `databricks_group_member` to improve performance ([#4581](#4581)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Support for unified provider for manual plugin framework resources.
To be merge after: #5115
Tests
Integration tests
Unit tests