Fix catalog name update using NewName field #5205
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The catalog Update operation was using the Name field to identify the catalog to be updated, but when the catalog name should be changed, the API requires using the NewName field instead. This fixes the bug where attempting to rename a catalog would silently fail because the old name was always used. Also adds a unit test (TestUpdateCatalogName) that reproduces and verifies the fix for this issue.
pierskarsenbarg
requested review from
renaudhartert-db
and removed request for
a team
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
renaudhartert-db
requested changes
Nov 10, 2025
Contributor
renaudhartert-db
left a comment
renaudhartert-db
left a comment
There was a problem hiding this comment.
Thanks for the PR @pierskarsenbarg! While the API allows for renaming, the operation is often problematic in TF as it mutates the identity of the resource and makes the apply non-idempotent (i.e. applying twice in a row will fail). We currently do not intend to support renaming in TF for UC resources.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The catalog Update operation was using the Name field to identify the catalog to be updated, but when the catalog name should be changed, it looks like the API requires using the NewName field instead. This fixes the bug where attempting to rename a catalog would silently fail because the old name was always used.
Also adds a unit test (TestUpdateCatalogName) that reproduces and verifies the fix for this issue.
Tests
make testrun locallydocs/folderinternal/acceptanceNEXT_CHANGELOG.mdfile