Skip to content

Commit 0f1d221

Browse files
committed
fix merge conflict and flaky unit test
Signed-off-by: Yi Jin <[email protected]>
1 parent aa9bccf commit 0f1d221

File tree

3 files changed

+9
-5
lines changed

3 files changed

+9
-5
lines changed

pkg/receive/handler_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1877,7 +1877,7 @@ func TestIngestorRestart(t *testing.T) {
18771877
},
18781878
}
18791879

1880-
err = client.handleRequest(ctx, 0, "test", data)
1880+
_, err = client.handleRequest(ctx, 0, "test", data)
18811881
require.NoError(t, err)
18821882

18831883
// close srv2 to simulate ingestor down
@@ -1889,7 +1889,7 @@ func TestIngestorRestart(t *testing.T) {
18891889

18901890
iter, errs := 10, 0
18911891
for i := 0; i < iter; i++ {
1892-
err = client.handleRequest(ctx, 0, "test", data)
1892+
_, err = client.handleRequest(ctx, 0, "test", data)
18931893
if err != nil {
18941894
require.Error(t, errUnavailable, err)
18951895
errs++

pkg/receive/multitsdb.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -636,7 +636,7 @@ func (t *MultiTSDB) startTSDB(logger log.Logger, tenantID string, tenant *tenant
636636
opts.EnableOverlappingCompaction = false
637637
s, err := tsdb.Open(
638638
dataDir,
639-
logger,
639+
level.NewFilter(logger, level.AllowError()),
640640
reg,
641641
&opts,
642642
nil,

pkg/store/bucket_test.go

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -694,7 +694,11 @@ func TestBucketStore_TSDBInfo(t *testing.T) {
694694
defer func() { testutil.Ok(t, bucketStore.Close()) }()
695695

696696
testutil.Ok(t, bucketStore.SyncBlocks(ctx))
697-
testutil.Equals(t, bucketStore.TSDBInfos(), []infopb.TSDBInfo{
697+
actual := bucketStore.TSDBInfos()
698+
sort.Slice(actual, func(i, j int) bool {
699+
return actual[i].Labels.String() < actual[j].Labels.String()
700+
})
701+
testutil.Equals(t, []infopb.TSDBInfo{
698702
{
699703
Labels: labelpb.ZLabelSet{Labels: []labelpb.ZLabel{{Name: "a", Value: "b"}}},
700704
MinTime: 0,
@@ -710,7 +714,7 @@ func TestBucketStore_TSDBInfo(t *testing.T) {
710714
MinTime: 0,
711715
MaxTime: 2000,
712716
},
713-
})
717+
}, actual)
714718
}
715719

716720
func TestBucketStore_Info(t *testing.T) {

0 commit comments

Comments
 (0)