Add chunk stats to a tracing span tag

Author: hczhu-db

pkg/store/proxy_merge.go

@@ -333,6 +333,9 @@ func newLazyRespSet(
 			l.span.SetTag("processed.chunks", seriesStats.Chunks)
 			l.span.SetTag("processed.samples", seriesStats.Samples)
 			l.span.SetTag("processed.bytes", bytesProcessed)
+			if len(seriesStats.ChunkSt) > 0 {
+				l.span.SetTag("processed.chunk_stats", seriesStats.ChunkSt)
+			}
 			l.span.Finish()
 		}()
 
@@ -491,6 +494,7 @@ func newAsyncRespSet(
 
 	switch retrievalStrategy {
 	case LazyRetrieval:
+		span.SetTag("retrival_strategy", LazyRetrieval)
 		return newLazyRespSet(
 			span,
 			frameTimeout,
@@ -503,6 +507,7 @@ func newAsyncRespSet(
 			emptyStreamResponses,
 		), nil
 	case EagerRetrieval:
+		span.SetTag("retrival_strategy", EagerRetrieval)
 		return newEagerRespSet(
 			span,
 			frameTimeout,
@@ -596,6 +601,9 @@ func newEagerRespSet(
 			l.span.SetTag("processed.chunks", seriesStats.Chunks)
 			l.span.SetTag("processed.samples", seriesStats.Samples)
 			l.span.SetTag("processed.bytes", bytesProcessed)
+			if len(seriesStats.ChunkSt) > 0 {
+				l.span.SetTag("processed.chunk_stats", seriesStats.ChunkSt)
+			}
 			l.span.Finish()
 			ret.wg.Done()
 		}()

pkg/store/storepb/custom.go

@@ -478,13 +478,19 @@ func (m *Chunk) XORNumSamples() int {
 	return 0
 }
 
+type ChunkStats struct {
+	MinTime, MaxTime int64
+	Samples          int
+}
+
 type SeriesStatsCounter struct {
 	lastSeriesHash uint64
 
 	Series  int
 	Chunks  int
 	Samples int
 	Bytes   uint64
+	ChunkSt []ChunkStats
 }
 
 func (c *SeriesStatsCounter) CountSeries(seriesLabels []labelpb.ZLabel) {
@@ -499,7 +505,10 @@ func (c *SeriesStatsCounter) Count(r *SeriesResponse) {
 	if r.GetSeries() != nil {
 		series := r.GetSeries()
 		c.CountSeries(series.Labels)
-		for _, chk := range series.Chunks {
+		c.ChunkSt = make([]ChunkStats, min(10, len(series.Chunks)))
+		for ci, chk := range series.Chunks {
+			// Keep the old value of c.Samples so that the samples in this chunck can be computed
+			accSamples := c.Samples
 			if chk.Raw != nil {
 				c.Chunks++
 				c.Samples += chk.Raw.XORNumSamples()
@@ -529,6 +538,11 @@ func (c *SeriesStatsCounter) Count(r *SeriesResponse) {
 				c.Chunks++
 				c.Samples += chk.Sum.XORNumSamples()
 			}
+			if ci < len(c.ChunkSt) {
+				c.ChunkSt[ci].MinTime = chk.MinTime
+				c.ChunkSt[ci].MaxTime = chk.MaxTime
+				c.ChunkSt[ci].Samples = c.Samples - accSamples
+			}
 		}
 	}