Skip to content

Commit 96440e6

Browse files
updated unit tests, passing
1 parent 086d155 commit 96440e6

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

internal/cortex/frontend/transport/utils/utils_test.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,23 +39,23 @@ func TestUpdateFailedQueryCache(t *testing.T) {
3939
queryExpressionNormalized: "test_query",
4040
queryExpressionRangeLength: 60,
4141
expectedResult: false,
42-
expectedMessageContains: "String regex conversion error",
42+
expectedMessageContains: "msg: String regex conversion error, normalized query: test_query, query range seconds: 60, updating cache for error: no error code here",
4343
},
4444
{
4545
name: "Non-cacheable error code",
4646
err: errors.New("Code(500)"),
4747
queryExpressionNormalized: "test_query",
4848
queryExpressionRangeLength: 60,
4949
expectedResult: false,
50-
expectedMessageContains: "Query not cached due to non-cacheable error code",
50+
expectedMessageContains: "msg: Query not cached due to non-cacheable error code, normalized query: test_query, query range seconds: 60, updating cache for error: Code(500)",
5151
},
5252
{
5353
name: "Cacheable error code",
5454
err: errors.New("Code(408)"),
5555
queryExpressionNormalized: "test_query",
5656
queryExpressionRangeLength: 60,
5757
expectedResult: true,
58-
expectedMessageContains: "Cached a failed query",
58+
expectedMessageContains: "msg: Cached a failed query, normalized query: test_query, range seconds: 60, updating cache for error: Code(408)",
5959
},
6060
}
6161

@@ -91,7 +91,7 @@ func TestQueryHitCache(t *testing.T) {
9191
queryExpressionNormalized: "test_query",
9292
queryExpressionRangeLength: 60,
9393
expectedResult: true,
94-
expectedMessageContains: "Retrieved query from cache",
94+
expectedMessageContains: "msg: Retrieved query from cache, normalized query: test_query, range seconds: 60",
9595
},
9696
{
9797
name: "Cache miss",

0 commit comments

Comments
 (0)