Skip to content

Commit e27fcc5

Browse files
committed
Fix group-replica error reporting
1 parent b2f8333 commit e27fcc5

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

pkg/query/endpointset.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -609,6 +609,8 @@ func (e *EndpointSet) GetStoreClients() []store.Client {
609609
StoreClient: storepb.NewStoreClient(er.cc),
610610
addr: er.addr,
611611
metadata: er.metadata,
612+
groupKey: er.GroupKey(),
613+
replicaKey: er.ReplicaKey(),
612614
})
613615
er.mtx.RUnlock()
614616
}

pkg/store/proxy.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -397,7 +397,10 @@ func (s *ProxyStore) Series(originalRequest *storepb.SeriesRequest, srv storepb.
397397

398398
logGroupReplicaErrors := func() {
399399
if len(failedStores) > 0 {
400-
level.Warn(s.logger).Log("msg", "Group/replica errors", "errors", failedStores)
400+
level.Warn(s.logger).Log("msg", "Group/replica errors",
401+
"errors", fmt.Sprintf("%+v", failedStores),
402+
"total_failed_stores", totalFailedStores,
403+
)
401404
}
402405
}
403406
defer logGroupReplicaErrors()
@@ -411,6 +414,7 @@ func (s *ProxyStore) Series(originalRequest *storepb.SeriesRequest, srv storepb.
411414
respSet, err := newAsyncRespSet(ctx, st, r, s.responseTimeout, s.retrievalStrategy, &s.buffers, r.ShardInfo, reqLogger, s.metrics.emptyStreamResponses)
412415
if err != nil {
413416
level.Error(reqLogger).Log("err", err)
417+
level.Warn(s.logger).Log("msg", "Store failure", "group", st.GroupKey(), "replica", st.ReplicaKey())
414418
bumpCounter(st.GroupKey(), st.ReplicaKey(), failedStores)
415419
totalFailedStores++
416420
if r.PartialResponseStrategy == storepb.PartialResponseStrategy_GROUP_REPLICA {

0 commit comments

Comments
 (0)