Skip to content

Commit 438edca

Browse files
committed
Update project file, makefile, and documentation
1 parent 5528d77 commit 438edca

File tree

4 files changed

+6
-7
lines changed

4 files changed

+6
-7
lines changed

CONTRIBUTING.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ warrant that you have the legal authority to do so.
1515

1616
## Python Compatibility
1717

18-
The code supports Python 3.9+ and has been tested with Python 3.9.21 and later.
18+
The code supports Python 3.10+ and has been tested with Python 3.10 and later.
1919

2020
## Quick Start
2121

@@ -29,7 +29,7 @@ make lint # Check code quality
2929

3030
# Run tests
3131
make test # Run tests
32-
make test-cov # Run tests with coverage report
32+
make coverage # Run tests with coverage report
3333

3434
# Build package
3535
make build # Build with modern build system
@@ -48,7 +48,7 @@ All dependencies are defined in `pyproject.toml`:
4848

4949
## Spark Dependencies
5050

51-
The builds have been tested against Spark 3.3.0+. This requires OpenJDK 1.8.56 or later version of Java 8.
51+
The builds have been tested against Spark 3.4.1+. This requires OpenJDK 1.8.56 or later version of Java 8.
5252
The Databricks runtimes use the Azul Zulu version of OpenJDK 8.
5353
These are not installed automatically by the build process.
5454

dbldatagen/_version.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,12 +51,12 @@ def _get_spark_version(sparkVersion: str) -> VersionInfo:
5151
match = r.match(sparkVersion)
5252

5353
if not match:
54-
raise AttributeError(f"Provided Spark version '{sparkVersion}' is invalid")
54+
raise ValueError(f"Provided Spark version '{sparkVersion}' is invalid")
5555

5656
major, minor, patch, release = match.groups()
5757
spark_version_info = VersionInfo(int(major), int(minor), int(patch), release, build="0")
5858

59-
except (RuntimeError, AttributeError):
59+
except (RuntimeError, ValueError):
6060
spark_version_info = VersionInfo(major=3, minor=0, patch=1, release="unknown", build="0")
6161
logger = logging.getLogger(__name__)
6262
logger.warning("Could not parse spark version - using assumed Spark Version : %s", spark_version_info)

makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
.PHONY: install install-dev test test-cov lint fmt clean build docs help
1+
.PHONY: dev test coverage lint fmt clean build docs
22

33
all: clean dev lint fmt test coverage
44

pyproject.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ classifiers = [
2121
"License :: Other/Proprietary License",
2222
"Operating System :: OS Independent",
2323
"Programming Language :: Python :: 3",
24-
"Programming Language :: Python :: 3.9",
2524
"Programming Language :: Python :: 3.10",
2625
"Programming Language :: Python :: 3.11",
2726
"Programming Language :: Python :: 3.12",

0 commit comments

Comments
 (0)