Clean-up lint messages

Author: ghanse

dbldatagen/column_generation_spec.py

@@ -480,7 +480,7 @@ def setBaseColumnDatatypes(self, columnDatatypes):
         assert type(columnDatatypes) is list, " `column_datatypes` parameter must be list"
         ensure(len(columnDatatypes) == len(self.baseColumns),
                "number of base column datatypes must match number of  base columns")
-        self._baseColumnDatatypes = [].append(columnDatatypes)
+        self._baseColumnDatatypes = columnDatatypes
 
     def _setupTemporaryColumns(self):
         """ Set up any temporary columns needed for test data generation.

dbldatagen/text_generators.py

@@ -77,7 +77,7 @@ def __str__(self):
         return f"TextGenerator(randomSeed={self._randomSeed})"
 
     def __eq__(self, other):
-        return type(self) == type(other) and self._randomSeed == other._randomSeed
+        return isinstance(self, type(other)) and self._randomSeed == other._randomSeed
 
     def withRandomSeed(self, seed):
         """ Set the random seed for the text generator
@@ -260,7 +260,7 @@ def __init__(self, template, escapeSpecialChars=False, extendedWordList=None):
             assert v is not None and isinstance(v, tuple) and len(v) == 2, "value must be tuple of length 2"
             mapping_length, mappings = v
             assert isinstance(mapping_length, int), "mapping length must be of type int"
-            assert isinstance(mappings, (list, np.ndarray)),\
+            assert isinstance(mappings, (list, np.ndarray)), \
                 "mappings are lists or numpy arrays"
             assert mapping_length == 0 or len(mappings) == mapping_length, "mappings must match mapping_length"
 
@@ -277,7 +277,7 @@ def __init__(self, template, escapeSpecialChars=False, extendedWordList=None):
             assert v is not None and isinstance(v, tuple) and len(v) == 2, "value must be tuple of length 2"
             mapping_length, mappings = v
             assert isinstance(mapping_length, int), "mapping length must be of type int"
-            assert mappings is None or isinstance(mappings, (list, np.ndarray)),\
+            assert mappings is None or isinstance(mappings, (list, np.ndarray)), \
                 "mappings are lists or numpy arrays"
 
             # for escaped mappings, the mapping can be None in which case the mapping is to the number itself

tests/test_basic_test.py

@@ -530,5 +530,5 @@ def test_library_version(self):
         lib_version = dg.__version__
 
         assert lib_version is not None
-        assert type(lib_version) == str, "__version__ is expected to be a string"
+        assert isinstance(lib_version, str), "__version__ is expected to be a string"
         assert len(lib_version.strip()) > 0, "__version__ is expected to be non-empty"

tests/test_columnGenerationSpec.py

@@ -59,40 +59,40 @@ def test_prefix(self):
         dt = StringType()
         cd = dg.ColumnGenerationSpec(name="test", colType=StringType(), prefix="test_")
         assert cd.prefix == "test_"
-        assert type(cd.datatype) == type(dt)
+        assert isinstance(cd.datatype, type(dt))
 
     def test_suffix(self):
         dt = StringType()
         cd = dg.ColumnGenerationSpec(name="test", colType=StringType(), suffix="_test")
         assert cd.suffix == "_test"
-        assert type(cd.datatype) == type(dt)
+        assert isinstance(cd.datatype, type(dt))
 
     def test_baseColumn(self):
         dt = StringType()
         cd = dg.ColumnGenerationSpec(name="test", colType=StringType(), baseColumn='test0')
         assert cd.baseColumn == 'test0', "baseColumn should be as expected"
         assert cd.baseColumns == ['test0']
-        assert type(cd.datatype) == type(dt)
+        assert isinstance(cd.datatype, type(dt))
 
     def test_baseColumnMultiple(self):
         dt = StringType()
         cd = dg.ColumnGenerationSpec(name="test", colType=StringType(), baseColumn=['test0', 'test_1'])
         assert cd.baseColumn == ['test0', 'test_1'], "baseColumn should be as expected"
         assert cd.baseColumns == ['test0', 'test_1']
-        assert type(cd.datatype) == type(dt)
+        assert isinstance(cd.datatype, type(dt))
 
     def test_baseColumnMultiple2(self):
         dt = StringType()
         cd = dg.ColumnGenerationSpec(name="test", colType=StringType(), baseColumn='test0,test_1')
         assert cd.baseColumn == 'test0,test_1', "baseColumn should be as expected"
         assert cd.baseColumns == ['test0', 'test_1']
-        assert type(cd.datatype) == type(dt)
+        assert isinstance(cd.datatype, type(dt))
 
     def test_expr(self):
         dt = StringType()
         cd = dg.ColumnGenerationSpec(name="test", colType=StringType(), baseColumn='test0,test_1', expr="concat(1,2)")
         assert cd.expr == 'concat(1,2)'
-        assert type(cd.datatype) == type(dt)
+        assert isinstance(cd.datatype, type(dt))
 
     def test_default_random_attribute(self):
         dt = StringType()

tests/test_quick_tests.py

@@ -767,7 +767,6 @@ def test_from_dict(self):
         assert new_gen.rowCount == 1000
         assert new_gen.partitions == 2
 
-
     def test_version_info(self):
         # test access to version info without explicit import
         print("Data generator version", dg.__version__)