Skip to content

Commit ba9bc8e

Browse files
authored
Removed scanner details message (#80)
* Removed scanner details message * Added display_rules to discovery class
1 parent bbfe878 commit ba9bc8e

File tree

3 files changed

+16
-3
lines changed

3 files changed

+16
-3
lines changed

discoverx/discovery.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,11 @@ def scan_result(self):
9595

9696
return self._scan_result.df
9797

98+
def display_rules(self):
99+
"""Displays the available rules in a friendly HTML format"""
100+
text = self.rules.get_rules_info()
101+
logger.friendlyHTML(text)
102+
98103
def search(
99104
self,
100105
search_term: str,

discoverx/scanner.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -384,9 +384,6 @@ def summary_html(self) -> str:
384384
To be more precise:
385385
</p>
386386
{summary_html_table}
387-
<p>
388-
You can see the full classification output with 'dx.scan_result'.
389-
</p>
390387
391388
392389
"""

tests/unit/discovery_test.py

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,17 @@ def test_discover_select_by_class(discover_ip):
9898
discover_ip.select_by_classes(from_tables="invalid from", by_classes="email")
9999

100100

101+
def test_discover_display_rules(capfd, discover_ip):
102+
# search a specific term and auto-detect matching classes/rules
103+
discover_ip.display_rules()
104+
105+
captured = capfd.readouterr()
106+
assert "Matching rules" in captured.out
107+
assert "built-in rules that are available to you:" in captured.out
108+
assert "mac_address - MAC Addresses" in captured.out
109+
assert "credit_card_expiration_date" in captured.out
110+
111+
101112
def test_discover_delete_by_class(spark, discover_ip):
102113
# search a specific term and auto-detect matching classes/rules
103114
discover_ip.delete_by_class(from_tables="*.default.tb_*", by_class="ip_v4", values="9.9.9.9")

0 commit comments

Comments
 (0)