Skip to content

Commit ecbbe81

Browse files
- Made secrets names for producer and consumer mandatory for running integration tests
- Modified Docs for running integration tests
1 parent 64b4dd0 commit ecbbe81

File tree

3 files changed

+12
-6
lines changed

3 files changed

+12
-6
lines changed

docs/content/getting_started/additionals.md

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,10 +37,8 @@ export DATABRICKS_TOKEN=<DATABRICKS TOKEN> # Account needs permission to create
3737
4. Provide databricks secret scope name : --eventhub_secrets_scope_name
3838
5. Provide eventhub producer access key name : --eventhub_producer_accesskey_name
3939
6. Provide eventhub consumer access key name : --eventhub_consumer_accesskey_name
40-
41-
Following are optional arguments for running EventHubs integration test
42-
1. Provide eventhub producer access key secret name (if different from `eventhub_producer_accesskey_name`) : --eventhub_producer_accesskey_secret_name
43-
2. Provide eventhub consumer access key secret name (if different from `eventhub_consumer_accesskey_name`) : --eventhub_consumer_accesskey_secret_name
40+
7. Provide eventhub producer access key secret name : --eventhub_producer_accesskey_secret_name
41+
8. Provide eventhub consumer access key secret name : --eventhub_consumer_accesskey_secret_name
4442

4543

4644
5c. Run the command for kafka ```python3 integration-tests/run-integration-test.py --cloud_provider_name=aws --dbr_version=11.3.x-scala2.12 --source=kafka --dbfs_path=dbfs:/tmp/DLT-META/ --kafka_topic_name=dlt-meta-integration-test --kafka_broker=host:9092```

integration-tests/conf/dlt-meta/eventhub-onboarding.template

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
},
1818
"bronze_reader_options": {
1919
"maxOffsetsPerTrigger": "50000",
20-
"startingOffsets": "latest",
20+
"startingOffsets": "earliest",
2121
"failOnDataLoss": "false",
2222
"kafka.request.timeout.ms": "60000",
2323
"kafka.session.timeout.ms": "60000"

integration-tests/run-integration-test.py

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -690,7 +690,15 @@ def process_arguments():
690690
if source.lower() not in supported_sources:
691691
raise Exception("Invalid value for --source! Supported values: --source=cloudfiles")
692692
if source.lower() == "eventhub":
693-
eventhub_madatory_args = ["eventhub_name", "eventhub_producer_accesskey_name", "eventhub_consumer_accesskey_name", "eventhub_secrets_scope_name", "eventhub_namespace", "eventhub_port"]
693+
eventhub_madatory_args = ["eventhub_name",
694+
"eventhub_producer_accesskey_name",
695+
"eventhub_consumer_accesskey_name",
696+
"eventhub_secrets_scope_name",
697+
"eventhub_producer_accesskey_secret_name",
698+
"eventhub_consumer_accesskey_secret_name",
699+
"eventhub_namespace",
700+
"eventhub_port"
701+
]
694702
check_mandatory_arg(args, eventhub_madatory_args)
695703
if source.lower() == "kafka":
696704
kafka_madatory_args = ["kafka_topic_name", "kafka_broker"]

0 commit comments

Comments
 (0)