manage the acl_jobs error log properly

Author: lorenzorubi-db

dbclient/JobsClient.py

@@ -100,10 +100,7 @@ def log_job_configs(self, users_list=None, groups_list = None, log_file='jobs.lo
         jobs_log = self.get_export_dir() + log_file
         acl_jobs_log = self.get_export_dir() + acl_file
         error_logger = logging_utils.get_error_logger(wmconstants.WM_EXPORT, wmconstants.JOB_OBJECT, self.get_export_dir())
-        failed_job_log_file = logging_utils.get_error_log_file(
-            wmconstants.WM_EXPORT, wmconstants.JOB_OBJECT, self.get_export_dir()
-        )
-        failed_acl_log_file = logging_utils.get_error_log_file(
+        acl_error_logger = logging_utils.get_error_logger(
             wmconstants.WM_EXPORT, wmconstants.JOB_ACL_OBJECT, self.get_export_dir()
         )
         # pinned by cluster_user is a flag per cluster
@@ -113,10 +110,7 @@ def log_job_configs(self, users_list=None, groups_list = None, log_file='jobs.lo
             jl = list(filter(lambda x: x.get('creator_user_name', '') in users_list, jl_full))
         else:
             jl = jl_full
-        with open(jobs_log, "w") as log_fp, \
-                open(acl_jobs_log, 'w') as acl_fp, \
-                open(failed_job_log_file, "w") as failed_log_fp, \
-                open(failed_acl_log_file, "w") as failed_acl_log_file:
+        with open(jobs_log, "w") as log_fp, open(acl_jobs_log, 'w') as acl_fp:
             for x in jl:
                 job_id = x['job_id']
                 new_job_name = x['settings']['name'] + ':::' + str(job_id)
@@ -148,9 +142,11 @@ def log_job_configs(self, users_list=None, groups_list = None, log_file='jobs.lo
                         acl_fp.write(json.dumps(job_perms) + '\n')
                     else:
                         # job_acl is malformed, the job is written to error output file
-                        logging.error(f"The following job id {job_id} has malformed permissions: {json.dumps(job_perms)}")
-                        failed_log_fp.write(json.dumps(x) + '\n')
-                        failed_acl_log_file.write(json.dumps(job_perms) + '\n')
+                        message = f"The following job id {job_id} has malformed permissions: {json.dumps(job_perms)}"
+                        logging.error(message)
+                        logging_utils.log_response_error(acl_error_logger, {
+                            'error': message
+                        })
 
     def import_job_configs(self, log_file='jobs.log', acl_file='acl_jobs.log', job_map_file='job_id_map.log'):
         jobs_log = self.get_export_dir() + log_file