CodeQL warning

Author: lorenzorubi-db

dbclient/dbclient.py

@@ -268,21 +268,17 @@ def http_req(self, http_type, endpoint, json_params, version='2.0', print_json=F
                 message = "Error: {0} request failed with code {1}\n{2}".format(
                     http_type, http_status_code, raw_results.text
                 )
+                error_json = {
+                    'http_status_code': raw_results.status_code,
+                    'error': raw_results.text,
+                    'url': full_endpoint,
+                    'json': json_params,
+                }
                 if self.is_skip_failed():
                     logging.error(message)
-                    return {
-                        'http_status_code': raw_results.status_code,
-                        'error': raw_results.text,
-                        'url': full_endpoint,
-                        'json': json_params,
-                    }
+                    return error_json
                 else:
-                    logging.error({
-                        'http_status_code': raw_results.status_code,
-                        'error': raw_results.text,
-                        'url': full_endpoint,
-                        'json': json_params,
-                    })
+                    logging.error(error_json)
                     raise Exception(message)
             results = raw_results.json()
             if logging_utils.check_error(results):