Skip to content

Commit 013983d

Browse files
authored
Remove the "Is Terraform used" prompt (#1664)
## Changes The outcome of the prompt is not used and might confuse users. (We received feedback that it does confuse an user.) Moreover, in the near future we don't expect to use the Terraform state for ucx migration. ### Linked issues Was introduced for #393 ### Functionality - [ ] added relevant user documentation - [ ] added new CLI command - [ ] modified existing command: `databricks labs ucx ...` - [ ] added a new workflow - [ ] modified existing workflow: `...` - [ ] added a new table - [ ] modified existing table: `...` ### Tests <!-- How is this tested? Please see the checklist below and also describe any other relevant tests --> - [ ] manually tested - [ ] added unit tests - [ ] added integration tests - [ ] verified on staging environment (screenshot attached)
1 parent 933292e commit 013983d

File tree

3 files changed

+1
-6
lines changed

3 files changed

+1
-6
lines changed

README.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -557,7 +557,6 @@ access the configuration file from the command line. Here's the description of c
557557
* `spark_conf`: An optional dictionary of Spark configuration properties.
558558
* `override_clusters`: An optional dictionary mapping job cluster names to existing cluster IDs.
559559
* `policy_id`: An optional string representing the ID of the cluster policy.
560-
* `is_terraform_used`: A boolean value indicating whether some workspace resources are managed by Terraform.
561560
* `include_databases`: An optional list of strings representing the names of databases to include for migration.
562561

563562
[[back to top](#databricks-labs-ucx)]

src/databricks/labs/ucx/config.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,7 @@ class WorkspaceConfig: # pylint: disable=too-many-instance-attributes
4141
uber_spn_id: str | None = None
4242
uber_instance_profile: str | None = None
4343

44-
# Flag to see if terraform has been used for deploying certain entities
45-
is_terraform_used: bool = False
44+
is_terraform_used: bool = False # Not used, keep for backwards compatability
4645

4746
# Whether the assessment should capture a specific list of databases, if not specified, it will list all databases.
4847
include_databases: list[str] | None = None

src/databricks/labs/ucx/install.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -212,8 +212,6 @@ def _prompt_for_new_installation(self) -> WorkspaceConfig:
212212
num_threads = int(self.prompts.question("Number of threads", default="8", valid_number=True))
213213
configure_groups = ConfigureGroups(self.prompts)
214214
configure_groups.run()
215-
# Check if terraform is being used
216-
is_terraform_used = self.prompts.confirm("Do you use Terraform to deploy your infrastructure?")
217215
include_databases = self._select_databases()
218216
trigger_job = self.prompts.confirm("Do you want to trigger assessment job after installation?")
219217
return WorkspaceConfig(
@@ -226,7 +224,6 @@ def _prompt_for_new_installation(self) -> WorkspaceConfig:
226224
renamed_group_prefix=configure_groups.renamed_group_prefix,
227225
log_level=log_level,
228226
num_threads=num_threads,
229-
is_terraform_used=is_terraform_used,
230227
include_databases=include_databases,
231228
trigger_job=trigger_job,
232229
)

0 commit comments

Comments
 (0)