Enforce mypy validation (#713)

Close #619

Author: nfx

pyproject.toml

@@ -66,10 +66,12 @@ coverage    = "pytest -n auto --cov src tests/unit --timeout 10 --cov-report=htm
 integration = "pytest -n 10 --cov src tests/integration"
 fmt         = ["isort .",
                "black .",
-               "ruff  . --fix"]
+               "ruff  . --fix",
+               "mypy ."]
 verify      = ["black --check .",
                "isort . --check-only",
-               "ruff ."]
+               "ruff .",
+               "mypy ."]
 
 [tool.isort]
 skip_glob = ["notebooks/*.py"]

src/databricks/labs/ucx/install.py

@@ -221,7 +221,7 @@ def run_for_config(
         workspace_installer = WorkspaceInstaller(
             ws, prefix=prefix, promtps=promtps, wheels=wheels, sql_backend=sql_backend
         )
-        logger.info(f"Installing UCX v{wheels.version()} on {ws.config.host}")
+        logger.info(f"Installing UCX v{workspace_installer._wheels.version()} on {ws.config.host}")
         workspace_installer._config = config
         workspace_installer._write_config(overwrite=False)
         workspace_installer._current_config.override_clusters = override_clusters

src/databricks/labs/ucx/workspace_access/generic.py

@@ -140,7 +140,9 @@ def _inflight_check(self, object_type: str, object_id: str, acl: list[iam.Access
     def _applier_task(self, object_type: str, object_id: str, acl: list[iam.AccessControlRequest]):
         retryable_exceptions = [InternalError, NotFound, ResourceConflict, TemporarilyUnavailable, DeadlineExceeded]
 
-        update_retry_on_value_error = retried(on=retryable_exceptions, timeout=self._verify_timeout)
+        update_retry_on_value_error = retried(
+            on=retryable_exceptions, timeout=self._verify_timeout  # type: ignore[arg-type]
+        )
         update_retried_check = update_retry_on_value_error(self._safe_update_permissions)
         update_retried_check(object_type, object_id, acl)
 

src/databricks/labs/ucx/workspace_access/scim.py

@@ -118,7 +118,9 @@ def _applier_task(self, group_id: str, value: list[iam.ComplexValue], property_n
         operations = [iam.Patch(op=iam.PatchOp.ADD, path=property_name, value=[e.as_dict() for e in value])]
         schemas = [iam.PatchSchema.URN_IETF_PARAMS_SCIM_API_MESSAGES_2_0_PATCH_OP]
 
-        patch_retry_on_value_error = retried(on=retryable_errors, timeout=self._verify_timeout)
+        patch_retry_on_value_error = retried(
+            on=retryable_errors, timeout=self._verify_timeout  # type: ignore[arg-type]
+        )
         patch_retried_check = patch_retry_on_value_error(self._safe_patch_group)
         patch_retried_check(group_id, operations, schemas)