Fix failing solution accelerator verification tests (#2648)

## Changes
LocalCodeLinter is unable to normalize python code at notebook cell
level
This PR fixes the issue

### Linked issues
None

### Functionality
None

### Tests
- [x] manually tested running `make solacc` on files that fail in CI

---------

Co-authored-by: Eric Vergnaud <[email protected]>

Author: ericvergnaud

src/databricks/labs/ucx/contexts/workspace_cli.py

@@ -202,6 +202,7 @@ def local_file_migrator(self):
     def local_code_linter(self):
         session_state = CurrentSessionState()
         return LocalCodeLinter(
+            self.notebook_loader,
             self.file_loader,
             self.folder_loader,
             self.path_lookup,

src/databricks/labs/ucx/source_code/linters/files.py

@@ -104,13 +104,15 @@ class LocalCodeLinter:
 
     def __init__(
         self,
+        notebook_loader: NotebookLoader,
         file_loader: FileLoader,
         folder_loader: FolderLoader,
         path_lookup: PathLookup,
         session_state: CurrentSessionState,
         dependency_resolver: DependencyResolver,
         context_factory: Callable[[], LinterContext],
     ) -> None:
+        self._notebook_loader = notebook_loader
         self._file_loader = file_loader
         self._folder_loader = folder_loader
         self._path_lookup = path_lookup
@@ -141,7 +143,13 @@ def lint(
 
     def lint_path(self, path: Path, linted_paths: set[Path] | None = None) -> Iterable[LocatedAdvice]:
         is_dir = path.is_dir()
-        loader = self._folder_loader if is_dir else self._file_loader
+        loader: DependencyLoader
+        if is_a_notebook(path):
+            loader = self._notebook_loader
+        elif path.is_dir():
+            loader = self._folder_loader
+        else:
+            loader = self._file_loader
         path_lookup = self._path_lookup.change_directory(path if is_dir else path.parent)
         root_dependency = Dependency(loader, path, not is_dir)  # don't inherit context when traversing folders
         graph = DependencyGraph(root_dependency, None, self._dependency_resolver, path_lookup, self._session_state)

tests/integration/source_code/test_jobs.py

@@ -207,6 +207,7 @@ def test_lint_local_code(simple_ctx):
     path_to_scan = Path(ucx_path, "src")
     # TODO: LocalCheckoutContext has to move into GlobalContext because of this hack
     linter = LocalCodeLinter(
+        light_ctx.notebook_loader,
         light_ctx.file_loader,
         light_ctx.folder_loader,
         light_ctx.path_lookup,

tests/unit/source_code/linters/test_files.py

@@ -121,7 +121,13 @@ def local_code_linter(mock_path_lookup, migration_index):
         mock_path_lookup,
     )
     return LocalCodeLinter(
-        file_loader, folder_loader, mock_path_lookup, session_state, resolver, lambda: LinterContext(migration_index)
+        notebook_loader,
+        file_loader,
+        folder_loader,
+        mock_path_lookup,
+        session_state,
+        resolver,
+        lambda: LinterContext(migration_index),
     )
 
 
@@ -194,6 +200,7 @@ def test_folder_has_repr():
     "path", [Path("/Users/eric.vergnaud/development/ucx/.venv/lib/python3.10/site-packages/spacy/pipe_analysis.py")]
 )
 def test_known_issues(path: Path, migration_index):
+    notebook_loader = NotebookLoader()
     file_loader = FileLoader()
     notebook_loader = NotebookLoader()
     folder_loader = FolderLoader(notebook_loader, file_loader)
@@ -205,6 +212,7 @@ def test_known_issues(path: Path, migration_index):
     pip_resolver = PythonLibraryResolver(allow_list)
     resolver = DependencyResolver(pip_resolver, notebook_resolver, import_resolver, import_resolver, path_lookup)
     linter = LocalCodeLinter(
+        notebook_loader,
         file_loader,
         folder_loader,
         path_lookup,