Preemptively fix unknown errors of Python AST parsing coming from astroid and ast libraries (#3027)

Author: nfx

src/databricks/labs/ucx/source_code/python/python_ast.py

@@ -25,7 +25,6 @@
     NodeNG,
     parse,
     Uninferable,
-    AstroidSyntaxError,
 )
 
 from databricks.labs.ucx.source_code.base import (
@@ -77,9 +76,7 @@ def maybe_parse(cls, code: str) -> MaybeTree:
             root = parse(code)
             tree = Tree(root)
             return MaybeTree(tree, None)
-        except AstroidSyntaxError as e:
-            return cls._definitely_failure('syntax-error', code, e)
-        except SystemError as e:
+        except Exception as e:  # pylint: disable=broad-exception-caught
             # see https://github.com/databrickslabs/ucx/issues/2976
             return cls._definitely_failure('system-error', code, e)
 
@@ -89,7 +86,7 @@ def _definitely_failure(message_code: str, source_code: str, e: Exception) -> Ma
             None,
             Failure(
                 code=message_code,
-                message=f"Failed to parse code `{source_code}`: {e}. Report this as an issue on UCX GitHub.",
+                message=f"Failed to parse code `{source_code}`: {type(e)}: {e}. Report this as an issue on UCX GitHub.",
                 # Lines and columns are both 0-based: the first line is line 0.
                 start_line=0,
                 start_col=0,

tests/unit/source_code/notebooks/test_cells.py

@@ -195,7 +195,7 @@ def test_graph_builder_parse_error(
     problems = analyser.build_graph()
     codes = {_.code for _ in problems}
 
-    assert codes == {'syntax-error'}
+    assert codes == {'system-error'}
 
 
 def test_parses_python_cell_with_magic_commands(simple_dependency_resolver, mock_path_lookup) -> None: