Skip to content

Commit 46f4239

Browse files
authored
Code Compatibility Dashboard: Fix broken links (#2347)
## Changes In our Code Compatibility dashboard, this PR fixes two problems: - The link to the workflow in the Markdown panel didn't have the correct #anchor; now it does. - The links in the table widget to the workflow and task definitions was not being rendered correctly and therefore didn't work. Now they do. ### Functionality - modified dashboard: _UCX Migration (Main)_ ### Tests - [X] manually tested - [X] verified on staging environment (screenshot attached) ### Screenshots Before: ![Dashboard with broken URL](https://github.com/user-attachments/assets/9645a864-5279-4b81-83ff-f722bf56fbda) After: ![Dashboard with correct (and working) URL](https://github.com/user-attachments/assets/3e14ebb5-8981-4198-b32f-fca817bd404a)
1 parent 4a2d9d4 commit 46f4239

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

src/databricks/labs/ucx/queries/migration/main/02_0_code_compatibility_problems.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,4 @@ problem code and workflow name. The table:
66
- Explains the problem with a human-readable message and a code.
77

88
The code compatibility problems are updated after running
9-
[Jobs Static Code Analysis Workflow](https://github.com/databrickslabs/ucx/blob/main/README.md#workflow-linter-workflow).
9+
[Jobs Static Code Analysis Workflow](https://github.com/databrickslabs/ucx/blob/main/README.md#jobs-static-code-analysis-workflow).

src/databricks/labs/ucx/queries/migration/main/02_1_code_compatibility_problems.sql

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
/*
22
--title 'Workflow migration problems'
33
--width 6
4-
--overrides '{"spec":
5-
{"encodings": {"columns": [
4+
--overrides '{"spec":{
5+
"encodings":{
6+
"columns": [
67
{"fieldName": "path", "booleanValues": ["false", "true"], "linkUrlTemplate": "/#workspace/{{ @ }}", "linkTextTemplate": "{{ @ }}", "linkTitleTemplate": "{{ @ }}", "linkOpenInNewTab": true, "type": "string", "displayAs": "link", "title": "path"},
78
{"fieldName": "code", "booleanValues": ["false", "true"], "type": "string", "displayAs": "string", "title": "code"},
89
{"fieldName": "message", "booleanValues": ["false", "true"], "type": "string", "displayAs": "string", "title": "message"},
@@ -12,10 +13,11 @@
1213
{"fieldName": "start_col", "booleanValues": ["false", "true"], "type": "integer", "displayAs": "number", "title": "start_col"},
1314
{"fieldName": "end_line", "booleanValues": ["false", "true"], "type": "integer", "displayAs": "number", "title": "end_line"},
1415
{"fieldName": "end_col", "booleanValues": ["false", "true"], "type": "integer", "displayAs": "number", "title": "end_col"}
15-
]}},
16+
]},
1617
"invisibleColumns": [
17-
{"fieldName": "workflow_id", "booleanValues": ["false", "true"], "linkUrlTemplate": "/jobs/{{ @ }}", "linkTextTemplate": "{{ @ }}", "linkTitleTemplate": "{{ @ }}", "linkOpenInNewTab": true, "type": "string", "displayAs": "link", "title": "workflow_id"}
18-
]}'
18+
{"name": "workflow_id", "booleanValues": ["false", "true"], "linkUrlTemplate": "/jobs/{{ @ }}", "linkTextTemplate": "{{ @ }}", "linkTitleTemplate": "{{ @ }}", "linkOpenInNewTab": true, "type": "string", "displayAs": "link", "title": "workflow_id"}
19+
]
20+
}}'
1921
*/
2022
SELECT
2123
path,

0 commit comments

Comments
 (0)