Skip to content

Commit 6ff3621

Browse files
authored
Return False when failed to migrate table (#2982)
Return `False` when failed to migrate.
1 parent 5423f58 commit 6ff3621

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

src/databricks/labs/ucx/hive_metastore/table_migrate.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ def _migrate_managed_table(self, managed_table_external_storage: str, src_table:
145145
if managed_table_external_storage == 'CLONE':
146146
return self._migrate_table_create_ctas(src_table.src, src_table.rule)
147147
logger.warning(f"failed-to-migrate: unknown managed_table_external_storage: {managed_table_external_storage}")
148-
return True
148+
return False
149149

150150
def _safe_migrate_table(
151151
self,

src/databricks/labs/ucx/hive_metastore/table_migration_status.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,8 @@ def is_migrated(self, schema: str, table: str) -> bool:
119119
return True
120120
logger.info(f"{schema}.{table} is set as not migrated")
121121
except NotFound:
122-
# If the source table doesn't exist, it will not be shown as migrated
122+
# If the source table doesn't exist anymore, we mark it as migrated to avoid trying to migrate it again and
123+
# for views that have the table as dependency
123124
logger.warning(f"failed-to-migrate: {schema}.{table} set as a source does no longer exist")
124125
return True
125126
return False

0 commit comments

Comments
 (0)