Throwing ManyError on migrate-groups tasks (#710)

Author: william-conti

src/databricks/labs/ucx/workspace_access/groups.py

@@ -391,8 +391,8 @@ def delete_original_workspace_groups(self):
             tasks.append(functools.partial(self._delete_workspace_group, mg.id_in_workspace, mg.temporary_name))
         _, errors = Threads.gather("removing original workspace groups", tasks)
         if len(errors) > 0:
-            msg = f"During account-to-workspace reflection got {len(errors)} errors. See debug logs"
-            raise RuntimeWarning(msg)
+            logger.error(f"During account-to-workspace reflection got {len(errors)} errors. See debug logs")
+            raise ManyError(errors)
 
     def _fetcher(self) -> Iterable[MigratedGroup]:
         for row in self._backend.fetch(f"SELECT * FROM {self._full_name}"):

src/databricks/labs/ucx/workspace_access/manager.py

@@ -134,7 +134,7 @@ def apply_group_permissions(self, migration_state: MigrationState):
         if len(errors) > 0:
             # TODO: https://github.com/databrickslabs/ucx/issues/406
             logger.error(f"Detected {len(errors)} while applying permissions")
-            return False
+            raise ManyError(errors)
         logger.info("Permissions were applied")
         return True
 

tests/unit/workspace_access/test_groups.py

@@ -449,7 +449,7 @@ def test_delete_original_workspace_groups_should_fail_if_delete_does_not_work():
     wsclient.groups.delete.side_effect = RuntimeError("Something bad")
     gm = GroupManager(backend, wsclient, inventory_database="inv")
 
-    with pytest.raises(RuntimeWarning):
+    with pytest.raises(ManyError):
         gm.delete_original_workspace_groups()