Fixed the issue of databricks labs ucx installations and databricks labs ucx manual-workspace-info. (#814)

Author: HariGS-DB

src/databricks/labs/ucx/installer/__init__.py

@@ -8,6 +8,7 @@
 from databricks.sdk import WorkspaceClient
 from databricks.sdk.errors import NotFound
 from databricks.sdk.service.iam import User
+from yaml import YAMLError
 
 from databricks.labs.ucx.config import WorkspaceConfig
 
@@ -47,6 +48,9 @@ def for_user(self, user: User) -> Installation:
         except TypeError:
             msg = f"Installation is corrupt for {user.user_name}"
             raise IllegalState(msg) from None
+        except YAMLError:
+            msg = f"Config file {config_file} is corrupted, check if it is in correct yaml format"
+            raise IllegalState(msg) from None
 
     def _maybe_for_user(self, user: User) -> Installation | None:
         try:

tests/unit/installer/test_installation_manager.py

@@ -1,8 +1,10 @@
 import io
-from unittest.mock import MagicMock
+from unittest.mock import MagicMock, create_autospec
 
 import pytest
+from databricks.labs.blueprint.installer import IllegalState
 from databricks.labs.blueprint.parallel import ManyError
+from databricks.sdk import WorkspaceClient
 from databricks.sdk.errors import NotFound
 from databricks.sdk.service.iam import ComplexValue, User
 from databricks.sdk.service.jobs import (
@@ -63,6 +65,26 @@ def test_corrupt_config(mocker):
     assert len(user_installations) == 0
 
 
+def test_for_user_corrupt_config_yaml(mocker):
+    ws = create_autospec(WorkspaceClient)
+    user = User(user_name="foo")
+    ws.users.list.return_value = [user]
+    ws.workspace.download.return_value = io.StringIO("version: 2\ntacl: extra colon: test")
+    installation_manager = InstallationManager(ws)
+    with pytest.raises(IllegalState):
+        installation_manager.for_user(user)
+
+
+def test_user_installations_corrupt_config_yaml(mocker):
+    ws = create_autospec(WorkspaceClient)
+    user = User(user_name="foo")
+    ws.users.list.return_value = [user]
+    ws.workspace.download.return_value = io.StringIO("version: 2\ntacl: extra colon: test")
+    installation_manager = InstallationManager(ws)
+    user_installations = installation_manager.user_installations()
+    assert len(user_installations) == 0
+
+
 def test_validate_assessment(mocker):
     ws = mocker.patch("databricks.sdk.WorkspaceClient.__init__")
     current_user = MagicMock()