Skip to content

Commit b635244

Browse files
authored
[chore] use specific assertions for external location verification (#2985)
1 parent 4cc5c83 commit b635244

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

tests/integration/hive_metastore/test_external_locations.py

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -80,16 +80,16 @@ def test_external_locations(ws, sql_backend, inventory_schema, env_or_skip):
8080
mounts_crawler = MountsCrawler(sql_backend, ws, inventory_schema)
8181
crawler = ExternalLocations(ws, sql_backend, inventory_schema, tables_crawler, mounts_crawler)
8282
results = crawler.snapshot()
83-
assert len(results) == 6
84-
assert results[1].location == "s3://bar/test3/"
85-
assert (
86-
results[2].location
87-
== "jdbc:databricks://dbc-test1-aa11.cloud.databricks.com;httpPath=/sql/1.0/warehouses/65b52fb5bd86a7be"
88-
)
89-
assert results[3].location == "jdbc:mysql://somemysql.us-east-1.rds.amazonaws.com:3306/test_db"
90-
assert results[4].location == "jdbc:providerknown://somedb.us-east-1.rds.amazonaws.com:1234/test_db"
91-
assert results[4].table_count == 2
92-
assert results[5].location == "jdbc://providerunknown//somedb.us-east-1.rds.amazonaws.com:1234/test_db"
83+
assert results == [
84+
ExternalLocation('s3://test_location/', 2),
85+
ExternalLocation('s3://bar/test3/', 1),
86+
ExternalLocation(
87+
'jdbc:databricks://dbc-test1-aa11.cloud.databricks.com;httpPath=/sql/1.0/warehouses/65b52fb5bd86a7be', 1
88+
),
89+
ExternalLocation('jdbc:mysql://somemysql.us-east-1.rds.amazonaws.com:3306/test_db', 1),
90+
ExternalLocation('jdbc:providerknown://somedb.us-east-1.rds.amazonaws.com:1234/test_db', table_count=2),
91+
ExternalLocation('jdbc://providerunknown//somedb.us-east-1.rds.amazonaws.com:1234/test_db', 1),
92+
]
9393

9494

9595
def test_save_external_location_mapping_missing_location(ws, sql_backend, inventory_schema, make_random):

0 commit comments

Comments
 (0)