Skip to content

Commit bd8214c

Browse files
authored
Improve logging colors for dark terminal backgrounds (#468)
<img width="1106" alt="image" src="https://github.com/databrickslabs/ucx/assets/259697/d37b595b-6338-415e-b07a-9ffb7b236061">
1 parent 6d0e824 commit bd8214c

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

src/databricks/labs/ucx/framework/logger.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ class NiceFormatter(logging.Formatter):
1616
def __init__(self, *, probe_tty: bool = False) -> None:
1717
super().__init__(fmt="%(asctime)s %(levelname)s [%(name)s] %(message)s", datefmt="%H:%M")
1818
self._levels = {
19-
logging.NOTSET: self._bold(f"{self.BLACK}TRACE"),
19+
logging.NOTSET: self._bold("TRACE"),
2020
logging.DEBUG: self._bold(f"{self.CYAN}DEBUG"),
2121
logging.INFO: self._bold(f"{self.GREEN} INFO"),
2222
logging.WARNING: self._bold(f"{self.YELLOW} WARN"),
@@ -34,8 +34,10 @@ def format(self, record: logging.LogRecord): # noqa: A003
3434
return super().format(record)
3535
ts = self.formatTime(record, datefmt="%H:%M")
3636
level = self._levels[record.levelno]
37-
# databricks.labs.ucx.foo -> d.l.ucx.foo
38-
name = ".".join(part if i > 1 else part[0] for i, part in enumerate(record.name.split(".")))
37+
# databricks.labs.ucx.foo.bar -> d.l.u.foo.bar
38+
module_split = record.name.split(".")
39+
last_two_modules = len(module_split) - 2
40+
name = ".".join(part if i >= last_two_modules else part[0] for i, part in enumerate(module_split))
3941
msg = record.msg
4042
if record.exc_info and not record.exc_text:
4143
record.exc_text = self.formatException(record.exc_info)
@@ -48,7 +50,7 @@ def format(self, record: logging.LogRecord): # noqa: A003
4850

4951
color_marker = self.GRAY
5052
if record.levelno in (logging.INFO, logging.WARNING):
51-
color_marker = self.BLACK + self.BOLD
53+
color_marker = self.BOLD
5254
elif record.levelno in (logging.ERROR, logging.FATAL):
5355
color_marker = self.RED + self.BOLD
5456
return f"{self.GRAY}{ts}{self.RESET} {level} {color_marker}[{name}] {msg}{self.RESET}"

0 commit comments

Comments
 (0)