Fixing the issue in workspace id flag in create-account-group command (#1094)

Author: prajin-29

src/databricks/labs/ucx/cli.py

@@ -102,7 +102,7 @@ def sync_workspace_info(a: AccountClient):
 
 @ucx.command(is_account=True)
 def create_account_groups(
-    a: AccountClient, prompts: Prompts, workspace_ids: list[int] | None = None, new_workspace_client=WorkspaceClient
+    a: AccountClient, prompts: Prompts, workspace_ids: str | None = None, new_workspace_client=WorkspaceClient
 ):
     """
     Crawl all workspaces configured in workspace_ids, then creates account level groups if a WS local group is not present
@@ -115,9 +115,14 @@ def create_account_groups(
     - Exist in workspaces A,B,C. It has same members in A,B, but not in C. Then, X and C_X will be created in the
     account
     """
+
     logger.info(f"Account ID: {a.config.account_id}")
+    if workspace_ids is not None:
+        workspace_id_list = [int(x.strip()) for x in workspace_ids.split(",")]
+    else:
+        workspace_id_list = None
     workspaces = AccountWorkspaces(a, new_workspace_client)
-    workspaces.create_account_level_groups(prompts, workspace_ids)
+    workspaces.create_account_level_groups(prompts, workspace_id_list)
 
 
 @ucx.command

tests/unit/test_cli.py

@@ -153,6 +153,16 @@ def test_create_account_groups():
     a.groups.list.assert_called_with(attributes="id")
 
 
+def test_create_account_groups_with_id():
+    a = create_autospec(AccountClient)
+    w = create_autospec(WorkspaceClient)
+    a.get_workspace_client.return_value = w
+    w.get_workspace_id.return_value = None
+    prompts = MockPrompts({})
+    with pytest.raises(ValueError, match="No workspace ids provided in the configuration found in the account"):
+        create_account_groups(a, prompts, workspace_ids="123,456", new_workspace_client=lambda: w)
+
+
 def test_manual_workspace_info(ws):
     prompts = MockPrompts({'Workspace name for 123': 'abc', 'Next workspace id': ''})
     manual_workspace_info(ws, prompts)