Skip to content

Commit c66893f

Browse files
authored
simplify code of airflow job detection (#2978)
## Changes Simplify code ### Linked issues None ### Functionality None ### Tests - [x] ran unit tests --------- Co-authored-by: Eric Vergnaud <[email protected]>
1 parent 2209174 commit c66893f

File tree

1 file changed

+5
-5
lines changed
  • src/databricks/labs/ucx/assessment

1 file changed

+5
-5
lines changed

src/databricks/labs/ucx/assessment/jobs.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -93,11 +93,11 @@ def _assess_jobs(self, all_jobs: list[BaseJob], all_clusters_by_id) -> Iterable[
9393
cluster_failures.extend(self._check_jar_task(job.settings.tasks))
9494
job_assessment[job_id].update(cluster_failures)
9595

96-
# TODO: next person looking at this - rewrite, as this code makes no sense
97-
for job_key in job_details.keys(): # pylint: disable=consider-using-dict-items,consider-iterating-dictionary
98-
job_details[job_key].failures = json.dumps(list(job_assessment[job_key]))
99-
if len(job_assessment[job_key]) > 0:
100-
job_details[job_key].success = 0
96+
for job_key, job_info in job_details.items():
97+
failures = job_assessment[job_key]
98+
job_info.failures = json.dumps(list(failures))
99+
if len(failures) > 0:
100+
job_info.success = 0
101101
return list(job_details.values())
102102

103103
@staticmethod

0 commit comments

Comments
 (0)