Rename packages: code -> source_code (#1128)

ericvergnaud · web-flow · commit ca3ea3526f35 · 2024-03-27T21:17:30.000+01:00
## Changes Renames 'code' module to 'source_code' ### Linked issues Resolves #1126 ### Functionality - [ ] added relevant user documentation - [ ] added new CLI command - [ ] modified existing command: `databricks labs ucx ...` - [ ] added a new workflow - [ ] modified existing workflow: `...` - [ ] added a new table - [ ] modified existing table: `...` ### Tests - [x] manually tested - [ ] added unit tests - [ ] added integration tests - [ ] verified on staging environment (screenshot attached) Tested by running existing unit tests
diff --git a/src/databricks/labs/ucx/cli.py b/src/databricks/labs/ucx/cli.py
@@ -20,7 +20,6 @@
 from databricks.labs.ucx.azure.access import AzureResourcePermissions
 from databricks.labs.ucx.azure.credentials import ServicePrincipalMigration
 from databricks.labs.ucx.azure.locations import ExternalLocationsMigration
-from databricks.labs.ucx.code.files import Files
 from databricks.labs.ucx.config import WorkspaceConfig
 from databricks.labs.ucx.hive_metastore import ExternalLocations, TablesCrawler
 from databricks.labs.ucx.hive_metastore.catalog_schema import CatalogSchema
@@ -29,6 +28,7 @@
 from databricks.labs.ucx.hive_metastore.table_move import TableMove
 from databricks.labs.ucx.install import WorkspaceInstallation
 from databricks.labs.ucx.installer.workflows import WorkflowsInstallation
+from databricks.labs.ucx.source_code.files import Files
 from databricks.labs.ucx.workspace_access.clusters import ClusterAccess
 from databricks.labs.ucx.workspace_access.groups import GroupManager
 
diff --git a/src/databricks/labs/ucx/source_code/__init__.py b/src/databricks/labs/ucx/source_code/__init__.py
diff --git a/src/databricks/labs/ucx/source_code/base.py b/src/databricks/labs/ucx/source_code/base.py
diff --git a/src/databricks/labs/ucx/source_code/files.py b/src/databricks/labs/ucx/source_code/files.py
@@ -4,8 +4,8 @@
 from databricks.sdk import WorkspaceClient
 from databricks.sdk.service.workspace import Language
 
-from databricks.labs.ucx.code.languages import Languages
 from databricks.labs.ucx.hive_metastore.table_migrate import TablesMigrate
+from databricks.labs.ucx.source_code.languages import Languages
 
 logger = logging.getLogger(__name__)
 
diff --git a/src/databricks/labs/ucx/source_code/languages.py b/src/databricks/labs/ucx/source_code/languages.py
@@ -1,9 +1,9 @@
 from databricks.sdk.service.workspace import Language
 
-from databricks.labs.ucx.code.base import Fixer, Linter, SequentialLinter
-from databricks.labs.ucx.code.pyspark import SparkSql
-from databricks.labs.ucx.code.queries import FromTable
 from databricks.labs.ucx.hive_metastore.table_migrate import Index
+from databricks.labs.ucx.source_code.base import Fixer, Linter, SequentialLinter
+from databricks.labs.ucx.source_code.pyspark import SparkSql
+from databricks.labs.ucx.source_code.queries import FromTable
 
 
 class Languages:
diff --git a/src/databricks/labs/ucx/source_code/lsp.py b/src/databricks/labs/ucx/source_code/lsp.py
@@ -12,15 +12,15 @@
 from databricks.labs.blueprint.logger import install_logger
 from databricks.sdk.service.workspace import Language
 
-from databricks.labs.ucx.code.base import (
+from databricks.labs.ucx.hive_metastore.table_migrate import Index, MigrationStatus
+from databricks.labs.ucx.source_code.base import (
     Advice,
     Advisory,
     Convention,
     Deprecation,
     Failure,
 )
-from databricks.labs.ucx.code.languages import Languages
-from databricks.labs.ucx.hive_metastore.table_migrate import Index, MigrationStatus
+from databricks.labs.ucx.source_code.languages import Languages
 
 logger = logging.getLogger(__name__)
 
diff --git a/src/databricks/labs/ucx/source_code/notebooks.py b/src/databricks/labs/ucx/source_code/notebooks.py
@@ -1,7 +1,7 @@
 from databricks.sdk import WorkspaceClient
 from databricks.sdk.service.workspace import ExportFormat, ObjectInfo
 
-from databricks.labs.ucx.code.languages import Languages
+from databricks.labs.ucx.source_code.languages import Languages
 
 
 class Notebooks:
diff --git a/src/databricks/labs/ucx/source_code/pyspark.py b/src/databricks/labs/ucx/source_code/pyspark.py
@@ -1,8 +1,8 @@
 import ast
 from collections.abc import Iterable
 
-from databricks.labs.ucx.code.base import Advice, Fixer, Linter
-from databricks.labs.ucx.code.queries import FromTable
+from databricks.labs.ucx.source_code.base import Advice, Fixer, Linter
+from databricks.labs.ucx.source_code.queries import FromTable
 
 
 class SparkSql(Linter, Fixer):
diff --git a/src/databricks/labs/ucx/source_code/queries.py b/src/databricks/labs/ucx/source_code/queries.py
@@ -3,8 +3,8 @@
 import sqlglot
 from sqlglot.expressions import Table
 
-from databricks.labs.ucx.code.base import Advice, Deprecation, Fixer, Linter
 from databricks.labs.ucx.hive_metastore.table_migrate import Index
+from databricks.labs.ucx.source_code.base import Advice, Deprecation, Fixer, Linter
 
 
 class FromTable(Linter, Fixer):
diff --git a/src/databricks/labs/ucx/source_code/redash.py b/src/databricks/labs/ucx/source_code/redash.py
@@ -1,7 +1,7 @@
 from databricks.sdk import WorkspaceClient
 from databricks.sdk.service.sql import Query
 
-from databricks.labs.ucx.code.base import Fixer
+from databricks.labs.ucx.source_code.base import Fixer
 
 
 class Redash:
diff --git a/tests/unit/source_code/__init__.py b/tests/unit/source_code/__init__.py
diff --git a/tests/unit/source_code/conftest.py b/tests/unit/source_code/conftest.py
diff --git a/tests/unit/source_code/test_base.py b/tests/unit/source_code/test_base.py
@@ -1,4 +1,4 @@
-from databricks.labs.ucx.code.base import (
+from databricks.labs.ucx.source_code.base import (
     Advice,
     Advisory,
     Convention,
diff --git a/tests/unit/source_code/test_files.py b/tests/unit/source_code/test_files.py
@@ -5,8 +5,8 @@
 import pytest
 from databricks.sdk.service.workspace import Language
 
-from databricks.labs.ucx.code.files import Files
-from databricks.labs.ucx.code.languages import Languages
+from databricks.labs.ucx.source_code.files import Files
+from databricks.labs.ucx.source_code.languages import Languages
 from tests.unit import workspace_client_mock
 
 
@@ -20,7 +20,6 @@ def test_files_fix_ignores_unsupported_extensions():
 def test_files_fix_ignores_unsupported_language():
     languages = create_autospec(Languages)
     files = Files(languages)
-    # pylint: disable=protected-access
     files._extensions[".py"] = None
     path = Path('unsupported.py')
     assert not files.apply(path)
diff --git a/tests/unit/source_code/test_languages.py b/tests/unit/source_code/test_languages.py
@@ -1,9 +1,9 @@
 import pytest
 from databricks.sdk.service.workspace import Language
 
-from databricks.labs.ucx.code.base import Fixer, Linter
-from databricks.labs.ucx.code.languages import Languages
 from databricks.labs.ucx.hive_metastore.table_migrate import Index
+from databricks.labs.ucx.source_code.base import Fixer, Linter
+from databricks.labs.ucx.source_code.languages import Languages
 
 index = Index([])
 
diff --git a/tests/unit/source_code/test_notebooks.py b/tests/unit/source_code/test_notebooks.py
@@ -3,8 +3,8 @@
 from databricks.sdk import WorkspaceClient
 from databricks.sdk.service.workspace import ExportFormat, Language, ObjectInfo
 
-from databricks.labs.ucx.code.languages import Languages
-from databricks.labs.ucx.code.notebooks import Notebooks
+from databricks.labs.ucx.source_code.languages import Languages
+from databricks.labs.ucx.source_code.notebooks import Notebooks
 
 
 def test_notebooks_revert_restores_original_code():
diff --git a/tests/unit/source_code/test_pyspark.py b/tests/unit/source_code/test_pyspark.py
@@ -1,6 +1,6 @@
-from databricks.labs.ucx.code.base import Deprecation
-from databricks.labs.ucx.code.pyspark import SparkSql
-from databricks.labs.ucx.code.queries import FromTable
+from databricks.labs.ucx.source_code.base import Deprecation
+from databricks.labs.ucx.source_code.pyspark import SparkSql
+from databricks.labs.ucx.source_code.queries import FromTable
 
 
 def test_spark_not_sql(empty_index):
diff --git a/tests/unit/source_code/test_queries.py b/tests/unit/source_code/test_queries.py
@@ -1,5 +1,5 @@
-from databricks.labs.ucx.code.base import Deprecation
-from databricks.labs.ucx.code.queries import FromTable
+from databricks.labs.ucx.source_code.base import Deprecation
+from databricks.labs.ucx.source_code.queries import FromTable
 
 
 def test_not_migrated_tables_trigger_nothing(empty_index):
