Remove unnecessary crawler API: Mounts.inventorize_mounts() (#2535)

## Changes

This PR removes the `Mounts.inventorize_mounts()` method; it was only
used by unit tests that could use the `.snapshot()` API instead. This
was noted as part of #2404, and is part of general cleanup of patterns
we use for the crawlers:


https://github.com/databrickslabs/ucx/blob/68ecb02df0f02fcef1b5dc44a8421ccf480431c6/src/databricks/labs/ucx/hive_metastore/locations.py#L240

### Linked issues

Relates to #2404.

### Tests

- updated unit tests

Author: asnare

src/databricks/labs/ucx/hive_metastore/locations.py

@@ -320,9 +320,6 @@ def _deduplicate_mounts(self, mounts: list) -> list:
                 deduplicated_mounts.append(obj)
         return deduplicated_mounts
 
-    def inventorize_mounts(self):
-        self._append_records(self._list_mounts())
-
     def _list_mounts(self) -> Iterable[Mount]:
         mounts = []
         for mount_point, source, _ in self._dbutils.fs.mounts():

tests/unit/hive_metastore/test_locations.py

@@ -75,7 +75,7 @@ def test_location_trie_tables():
     assert c_node.tables == tables
 
 
-def test_list_mounts_should_return_a_list_of_mount_without_encryption_type():
+def test_mounts_inventory_should_contain_mounts_without_encryption_type():
     client = create_autospec(WorkspaceClient)
     client.dbutils.fs.mounts.return_value = [
         MountInfo("mp_1", "path_1", "info_1"),
@@ -86,7 +86,7 @@ def test_list_mounts_should_return_a_list_of_mount_without_encryption_type():
     backend = MockBackend()
     instance = Mounts(backend, client, "test")
 
-    instance.inventorize_mounts()
+    instance.snapshot()
 
     assert [
         Row(name="mp_1", source="path_1"),
@@ -95,7 +95,7 @@ def test_list_mounts_should_return_a_list_of_mount_without_encryption_type():
     ] == backend.rows_written_for("hive_metastore.test.mounts", "append")
 
 
-def test_list_mounts_should_return_a_deduped_list_of_mount_without_encryption_type():
+def test_mounts_inventory_should_contain_deduped_mounts_without_encryption_type():
     client = create_autospec(WorkspaceClient)
     client.dbutils.fs.mounts.return_value = [
         MountInfo("mp_1", "path_1", "info_1"),
@@ -106,15 +106,15 @@ def test_list_mounts_should_return_a_deduped_list_of_mount_without_encryption_ty
     backend = MockBackend()
     instance = Mounts(backend, client, "test")
 
-    instance.inventorize_mounts()
+    instance.snapshot()
 
     assert [
         Row(name="mp_1", source="path_1"),
         Row(name="mp_2", source="path_2"),
     ] == backend.rows_written_for("hive_metastore.test.mounts", "append")
 
 
-def test_list_mounts_should_return_a_deduped_list_of_mount_without_variable_volume_names():
+def test_mounts_inventory_should_contain_deduped_mounts_without_variable_volume_names():
     client = create_autospec(WorkspaceClient)
     client.dbutils.fs.mounts.return_value = [
         MountInfo("/Volume", "DbfsReserved", "info_1"),
@@ -129,7 +129,7 @@ def test_list_mounts_should_return_a_deduped_list_of_mount_without_variable_volu
     backend = MockBackend()
     instance = Mounts(backend, client, "test")
 
-    instance.inventorize_mounts()
+    instance.snapshot()
 
     expected = [
         Row(name="/Volume", source="DbfsReserved"),