Skip to content

Commit cdc136b

Browse files
authored
Update TODO about dashboard installation retry on InternalError (#2338)
## Changes Update TODO about dashboard installation retry on `InternalError` to be more descriptive and actionable. ### Linked issues Resolves #2172 Resolves #2173 Resolves #2198
1 parent 0065b6c commit cdc136b

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

src/databricks/labs/ucx/install.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -591,8 +591,9 @@ def _handle_existing_dashboard(self, dashboard_id: str, display_name: str, paren
591591
return None # Recreate the dashboard if it's reference is corrupted (manually)
592592
return dashboard_id # Update the existing dashboard
593593

594-
# TODO: Confirm the assumption below is correct
595-
# An InternalError may occur when the dashboard is being published and the database does not exists
594+
# TODO: @JCZuurmond: wait for dashboard team to fix the error below,
595+
# then update the retry decorator and document why this is needed
596+
# databricks.sdk.errors.platform.InternalError: A database error occurred during import-dashboard-new
596597
@retried(on=[InternalError], timeout=timedelta(minutes=4))
597598
def _create_dashboard(self, folder: Path, *, parent_path: str) -> None:
598599
"""Create a lakeview dashboard from the SQL queries in the folder"""

0 commit comments

Comments
 (0)