Skip to content

Commit e5e0562

Browse files
authored
Resolve open TODO about retry on errors deployed during Lakeview dashboard deployment (#2501)
1 parent 54d9eec commit e5e0562

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/databricks/labs/ucx/install.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -603,9 +603,9 @@ def _handle_existing_dashboard(self, dashboard_id: str, display_name: str, paren
603603
return None # Recreate the dashboard if it's reference is corrupted (manually)
604604
return dashboard_id # Update the existing dashboard
605605

606-
# TODO: @JCZuurmond: wait for dashboard team to fix the error below,
607-
# then update the retry decorator and document why this is needed
608-
# databricks.sdk.errors.platform.InternalError: A database error occurred during import-dashboard-new
606+
# InternalError and DeadlineExceeded are retried because of Lakeview internal issues
607+
# These issues have been reported to and are resolved by the Lakeview team
608+
# Keeping the retry for resilience
609609
@retried(on=[InternalError, DeadlineExceeded], timeout=timedelta(minutes=4))
610610
def _create_dashboard(self, folder: Path, *, parent_path: str) -> None:
611611
"""Create a lakeview dashboard from the SQL queries in the folder"""

0 commit comments

Comments
 (0)