Skip to content

Commit ef45443

Browse files
authored
Let dashboard name adhere to naming convention (#3789)
## Changes Dashboard names should only contain alphanumeric characters (a-z, A-Z, 0-9), hyphens (-), or underscores (_) Fix for failing tests in https://github.com/databrickslabs/ucx/actions/runs/13559322493 ### Linked issues Resolves #3761 Resolves #3762 Resolves #3763 Resolves #3764 Resolves #3769 Resolves #3770 Resolves #3771 Resolves #3772 Resolves #3773 Resolves #3774 Resolves #3775 Resolves #3776 Resolves #3777 Resolves #3778 Resolves #3779 Resolves #3780 Resolves #3781 Resolves #3782 Resolves #3783 Resolves #3784 Resolves #3785 Resolves #3786 Resolves #3787 Resolves #3788 ### Functionality - [x] modified existing command: `databricks labs install ucx` ### Tests - [x] manually tested
1 parent 864fdff commit ef45443

File tree

2 files changed

+9
-4
lines changed

2 files changed

+9
-4
lines changed

src/databricks/labs/ucx/install.py

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -663,6 +663,15 @@ def _create_dashboard(self, folder: Path, *, parent_path: str) -> None:
663663
)
664664
)
665665
metadata.display_name = f"{self._name('UCX ')} {folder.parent.stem.title()} ({folder.stem.title()})"
666+
# TODO: Remove temporary fix for the dashboard name:
667+
# resource names should only contain alphanumeric characters (a-z, A-Z, 0-9), hyphens (-), or underscores (_)
668+
metadata.display_name = (
669+
metadata.display_name.replace(" ", "_")
670+
.replace("[", "-")
671+
.replace("]", "-")
672+
.replace("(", "")
673+
.replace(")", "")
674+
)
666675
reference = f"{folder.parent.stem}_{folder.stem}".lower()
667676
dashboard_id = self._install_state.dashboards.get(reference)
668677
if dashboard_id is not None:

src/databricks/labs/ucx/queries/progress/main/02_0_owner.filter.yml

Lines changed: 0 additions & 4 deletions
This file was deleted.

0 commit comments

Comments
 (0)