Skip to content

Commit f1f99cb

Browse files
authored
Verify CODEOWNERS flow (#136)
1 parent d95c089 commit f1f99cb

File tree

2 files changed

+14
-11
lines changed

2 files changed

+14
-11
lines changed

CODEOWNERS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
* @nfx @larsgeorge-db
1+
* @nfx @larsgeorge-db

CONTRIBUTING.md

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -133,14 +133,17 @@ make lint test
133133

134134
Here are the example steps to submit your first contribution:
135135

136-
1. `git checkout -b FEATURENAME`
137-
2. .. do the work
138-
3. `make fmt`
139-
4. `make lint`
140-
5. .. fix if any
141-
6. `make test`
136+
1. `git checkout main` (or `gcm` if you're using [ohmyzsh](https://ohmyz.sh/)).
137+
2. `git pull` (or `gl` if you're using [ohmyzsh](https://ohmyz.sh/)).
138+
3. `git checkout -b FEATURENAME` (or `gcb FEATURENAME` if you're using [ohmyzsh](https://ohmyz.sh/)).
139+
4. .. do the work
140+
5. `make fmt`
141+
6. `make lint`
142142
7. .. fix if any
143-
8. `git commit -a`
144-
9. `git push origin FEATURENAME`
145-
10. go to GitHub UI and create PR. Alternatively, `gh pr create` (if you have [GitHub CLI](https://cli.github.com/) installed).
146-
11. announce PR for the review
143+
8. `make test`
144+
9. .. fix if any
145+
10. `git commit -a`. Make sure to enter meaningful commit message title.
146+
11. `git push origin FEATURENAME`
147+
12. go to GitHub UI and create PR. Alternatively, `gh pr create` (if you have [GitHub CLI](https://cli.github.com/) installed).
148+
Make sure to use meaningful pull request title, because it'll appear in the release notes.
149+
13. announce PR for the review

0 commit comments

Comments
 (0)