Skip to content

Commit 090392b

Browse files
committed
fix: add SASL
1 parent 174e3bd commit 090392b

File tree

4 files changed

+16
-4
lines changed

4 files changed

+16
-4
lines changed

apps/basket/src/lib/kafka.test.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,11 @@ describe('Kafka Producer and Consumer', () => {
2020
initialRetryTime: 100,
2121
retries: 8,
2222
},
23+
sasl: {
24+
mechanism: 'scram-sha-256',
25+
username: process.env.KAFKA_USER as string,
26+
password: process.env.KAFKA_PASSWORD as string,
27+
},
2328
});
2429

2530
producer = kafka.producer();
@@ -72,6 +77,7 @@ describe('Kafka Producer and Consumer', () => {
7277
await admin.connect();
7378

7479
const topics = await admin.listTopics();
80+
console.log('topics', topics);
7581
expect(Array.isArray(topics)).toBe(true);
7682

7783
await admin.disconnect();

apps/basket/src/lib/producer.test.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,11 @@ describe('Producer Module', () => {
1616
kafka = new Kafka({
1717
clientId: 'producer-test',
1818
brokers: [KAFKA_BROKERS],
19+
sasl: {
20+
mechanism: 'scram-sha-256',
21+
username: process.env.KAFKA_USER as string,
22+
password: process.env.KAFKA_PASSWORD as string,
23+
},
1924
retry: {
2025
initialRetryTime: 100,
2126
retries: 8,
@@ -264,9 +269,6 @@ describe('Producer Module', () => {
264269
expect(disconnectProducer).toBeDefined();
265270
});
266271

267-
it('should be idempotent', async () => {
268-
expect(disconnectProducer).toBeDefined();
269-
});
270272
});
271273

272274
describe('Analytics Events', () => {

apps/basket/src/lib/producer.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ if (BROKER) {
6868
requestTimeout: KAFKA_TIMEOUT,
6969
sasl:{
7070
mechanism: 'scram-sha-256',
71-
username: process.env.KAFKA_USERNAME as string,
71+
username: process.env.KAFKA_USER as string,
7272
password: process.env.KAFKA_PASSWORD as string,
7373
}
7474
});

infra/ingest/vector.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@ sources:
22
redpanda:
33
type: kafka
44
bootstrap_servers: "${REDPANDA_BROKER}"
5+
sasl:
6+
mechanism: "scram-sha-256"
7+
username: "${VECTOR_KAFKA_USER}"
8+
password: "${VECTOR_KAFKA_PASSWORD}"
59
group_id: vector-analytics
610
topics:
711
- analytics-events

0 commit comments

Comments
 (0)