Skip to content

Commit 19cda7f

Browse files
committed
cleanup order of items
1 parent b7acdd9 commit 19cda7f

File tree

4 files changed

+18
-18
lines changed

4 files changed

+18
-18
lines changed

apps/dashboard/app/(main)/websites/[id]/_components/tabs/overview-tab.tsx

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -416,15 +416,15 @@ export function WebsiteOverviewTab({
416416
...(visibleMetrics.pageviews && {
417417
pageviews: event.pageviews as number,
418418
}),
419+
...(visibleMetrics.sessions && {
420+
sessions: event.sessions as number,
421+
}),
419422
...(visibleMetrics.visitors && {
420423
visitors:
421424
(event.visitors as number) ||
422425
(event.unique_visitors as number) ||
423426
0,
424427
}),
425-
...(visibleMetrics.sessions && {
426-
sessions: event.sessions as number,
427-
}),
428428
...(visibleMetrics.bounce_rate && {
429429
bounce_rate: event.bounce_rate as number,
430430
}),
@@ -488,7 +488,7 @@ export function WebsiteOverviewTab({
488488

489489
const formatNumber = useCallback(
490490
(value: number | null | undefined): string => {
491-
if (value == null || Number.isNaN(value)) {
491+
if (value === null || value === undefined || Number.isNaN(value)) {
492492
return "0";
493493
}
494494
return Intl.NumberFormat(undefined, {
@@ -808,15 +808,6 @@ export function WebsiteOverviewTab({
808808
chartData: miniChartData.pageviews,
809809
trend: calculateTrends.pageviews,
810810
},
811-
{
812-
id: "visitors-chart",
813-
title: "Visitors",
814-
value: analytics.summary?.unique_visitors || 0,
815-
description: `${formatNumber(todayVisitors)} today`,
816-
icon: UsersIcon,
817-
chartData: miniChartData.visitors,
818-
trend: calculateTrends.visitors,
819-
},
820811
{
821812
id: "sessions-chart",
822813
title: "Sessions",
@@ -826,6 +817,15 @@ export function WebsiteOverviewTab({
826817
chartData: miniChartData.sessions,
827818
trend: calculateTrends.sessions,
828819
},
820+
{
821+
id: "visitors-chart",
822+
title: "Visitors",
823+
value: analytics.summary?.unique_visitors || 0,
824+
description: `${formatNumber(todayVisitors)} today`,
825+
icon: UsersIcon,
826+
chartData: miniChartData.visitors,
827+
trend: calculateTrends.visitors,
828+
},
829829
{
830830
id: "bounce-rate-chart",
831831
title: "Bounce Rate",

apps/dashboard/components/charts/metrics-chart-with-annotations.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ export function MetricsChartWithAnnotations({
8686
end_date: dateRange.endDate.toISOString(),
8787
granularity: "daily",
8888
},
89-
metrics: ["pageviews", "visitors", "sessions"],
89+
metrics: ["pageviews", "sessions", "visitors"],
9090
};
9191
}, [dateRange, data]);
9292

apps/dashboard/components/charts/metrics-chart.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -307,8 +307,8 @@ type MetricsChartProps = {
307307

308308
const DEFAULT_METRICS = [
309309
"pageviews",
310-
"visitors",
311310
"sessions",
311+
"visitors",
312312
"bounce_rate",
313313
"median_session_duration",
314314
];

apps/dashboard/components/charts/metrics-constants.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,7 @@ export const formatPerformanceTime = (value: number): string => {
185185
};
186186

187187
export const formatCLS = (value: number): string => {
188-
if (value == null || Number.isNaN(value)) {
188+
if (value === null || value === undefined || Number.isNaN(value)) {
189189
return "N/A";
190190
}
191191
return value.toFixed(3);
@@ -213,10 +213,10 @@ export const ANALYTICS_METRICS: MetricConfig[] = [
213213
createMetric("pageviews", "Pageviews", "pageviews", Eye, (value) =>
214214
value.toLocaleString()
215215
),
216-
createMetric("visitors", "Visitors", "visitors", Users, (value) =>
216+
createMetric("sessions", "Sessions", "sessions", TrendingUp, (value) =>
217217
value.toLocaleString()
218218
),
219-
createMetric("sessions", "Sessions", "sessions", TrendingUp, (value) =>
219+
createMetric("visitors", "Visitors", "visitors", Users, (value) =>
220220
value.toLocaleString()
221221
),
222222
createMetric(

0 commit comments

Comments
 (0)