Skip to content

Commit 34e6fa2

Browse files
authored
fix(funnels): SQL error (#168)
1 parent c3f6a95 commit 34e6fa2

File tree

1 file changed

+12
-3
lines changed

1 file changed

+12
-3
lines changed

packages/rpc/src/lib/analytics-utils.ts

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -139,6 +139,15 @@ const buildStepQuery = (
139139
AND time >= parseDateTimeBestEffort({startDate:String})
140140
AND time <= parseDateTimeBestEffort({endDate:String})
141141
AND event_name = {${targetKey}:String}${filterConditions}
142+
143+
UNION DISTINCT
144+
145+
SELECT DISTINCT session_id
146+
FROM analytics.custom_events
147+
WHERE client_id = {websiteId:String}
148+
AND timestamp >= parseDateTimeBestEffort({startDate:String})
149+
AND timestamp <= parseDateTimeBestEffort({endDate:String})
150+
AND event_name = {${targetKey}:String}
142151
),
143152
session_referrers AS (
144153
SELECT
@@ -178,9 +187,9 @@ const buildStepQuery = (
178187
AND ce.timestamp >= parseDateTimeBestEffort({startDate:String})
179188
AND ce.timestamp <= parseDateTimeBestEffort({endDate:String})
180189
AND ce.event_name = {${targetKey}:String}
181-
)${includeReferrer ? `
182-
LEFT JOIN session_referrers sr ON session_id = sr.session_id` : ''}
183-
GROUP BY session_id${includeReferrer ? ', sr.session_referrer' : ''}`;
190+
) AS event_union${includeReferrer ? `
191+
LEFT JOIN session_referrers sr ON event_union.session_id = sr.session_id` : ''}
192+
GROUP BY event_union.session_id${includeReferrer ? ', sr.session_referrer' : ''}`;
184193
};
185194

186195
const processSessionEvents = (

0 commit comments

Comments
 (0)