Skip to content

Commit 35f13a4

Browse files
committed
feat: better custom events
1 parent f908763 commit 35f13a4

File tree

4 files changed

+15
-5
lines changed

4 files changed

+15
-5
lines changed

apps/dashboard/app/(main)/websites/[id]/_components/filters-section.tsx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -236,6 +236,9 @@ export function FiltersSection({
236236
<div className="flex shrink-0 gap-2">
237237
<Button
238238
className="h-7 font-medium text-xs"
239+
data-filter-id={editingFilter.id}
240+
data-total-filters={selectedFilters.length}
241+
data-track="filter_edit_completed"
239242
disabled={isSaving || selectedFilters.length === 0}
240243
onClick={handleSaveEdit}
241244
size="sm"

apps/dashboard/components/layout/navigation/navigation-item.tsx

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ interface NavigationItemProps extends Omit<NavigationItemType, 'icon'> {
1212
isRootLevel: boolean;
1313
isExternal?: boolean;
1414
currentWebsiteId?: string | null;
15+
sectionName?: string;
1516
}
1617

1718
export function NavigationItem({
@@ -26,6 +27,7 @@ export function NavigationItem({
2627
currentWebsiteId,
2728
domain,
2829
disabled,
30+
sectionName,
2931
}: NavigationItemProps) {
3032
const pathname = usePathname();
3133

@@ -115,11 +117,10 @@ export function NavigationItem({
115117
? 'border-sidebar-ring border-r-2 bg-sidebar-accent font-medium text-sidebar-accent-foreground'
116118
: 'text-sidebar-foreground/70'
117119
)}
118-
data-is-external={isExternal ? 'true' : 'false'}
119-
data-nav-item={name.toLowerCase().replace(/\s+/g, '-')}
120-
data-nav-section={isRootLevel ? 'main-nav' : 'website-nav'}
121-
data-nav-type={isRootLevel ? 'main' : 'website'}
122-
data-track="navigation-click"
120+
data-nav-href={href}
121+
data-nav-item={name}
122+
data-nav-section={sectionName || 'main'}
123+
data-track="navigation-item-click"
123124
role="menuitem"
124125
>
125126
{content}

apps/dashboard/components/layout/navigation/navigation-section.tsx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -133,6 +133,8 @@ export const NavigationSection = memo(function NavigationSectionComponent({
133133
<div className="border-sidebar-border/30 border-b border-dotted last:border-b-0">
134134
<button
135135
className="flex w-full items-center gap-3 px-3 py-2.5 text-left font-medium text-sidebar-foreground text-sm transition-colors hover:bg-sidebar-accent/50 focus:outline-none"
136+
data-section={title}
137+
data-track="navigation-section-toggle"
136138
onClick={() => toggleAccordion(title, true)}
137139
type="button"
138140
>
@@ -187,6 +189,7 @@ export const NavigationSection = memo(function NavigationSectionComponent({
187189
isRootLevel={!!item.rootLevel}
188190
name={item.name}
189191
production={item.production}
192+
sectionName={title}
190193
/>
191194
</div>
192195
);

apps/dashboard/components/layout/sidebar.tsx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -194,6 +194,7 @@ export function Sidebar() {
194194
<div className="flex items-center gap-3">
195195
<Button
196196
aria-label="Toggle navigation menu"
197+
data-track="sidebar-toggle"
197198
onClick={toggleSidebar}
198199
size="icon"
199200
type="button"
@@ -204,6 +205,7 @@ export function Sidebar() {
204205

205206
<Link
206207
className="flex items-center gap-2 transition-opacity hover:opacity-80"
208+
data-track="logo-click"
207209
href="/websites"
208210
>
209211
<div className="flex h-8 w-8 items-center justify-center">
@@ -259,6 +261,7 @@ export function Sidebar() {
259261
<Button
260262
aria-label="Close sidebar"
261263
className="absolute top-3 right-3 z-50 h-8 w-8 p-0 md:hidden"
264+
data-track="sidebar-close"
262265
onClick={closeSidebar}
263266
size="sm"
264267
type="button"

0 commit comments

Comments
 (0)