chore: fix more linter issues (#47)

* chore: add 'chrome' to globals in biome configuration

* refactor: streamline compression stream initialization and enhance type safety in Stripe webhook handling

* chore: fix moar lint issues

* chore: address coderabbit suggestions

* refactor: optimize isMaskedSecret function using useCallback

* chore: apply code formatting and clean up imports across multiple components

---------

Co-authored-by: Hyteq <[email protected]>

Author: AyanavaKarmakar

apps/api/src/agent/handlers/metric-handler.ts

@@ -53,7 +53,9 @@ function extractMetricValue(
 	queryData: unknown[],
 	defaultValue: unknown
 ): unknown {
-	if (!(queryData.length && queryData[0])) return defaultValue;
+	if (!(queryData.length && queryData[0])) {
+		return defaultValue;
+	}
 
 	const firstRow = queryData[0] as Record<string, unknown>;
 	const valueKey =

apps/api/src/agent/prompts/agent.ts

@@ -40,7 +40,7 @@ export const comprehensiveUnifiedPrompt = (
 	mode: 'analysis_only' | 'execute_chat' | 'execute_agent_step',
 	previousMessages?: any[],
 	agentToolResult?: any,
-	model?: 'chat' | 'agent' | 'agent-max'
+	_model?: 'chat' | 'agent' | 'agent-max'
 ) => `
 <persona>
 You are Nova, a world-class, specialized AI analytics assistant for the website ${websiteHostname}. You are precise, analytical, and secure. Your sole purpose is to help users understand their website's analytics data by providing insights, generating SQL queries, and creating visualizations.

apps/api/src/agent/utils/sql-validator.ts

@@ -22,7 +22,9 @@ export function validateSQL(sql: string): boolean {
 
 	// Check for dangerous keyword patterns
 	for (const keyword of FORBIDDEN_SQL_KEYWORDS) {
-		if (upperSQL.includes(keyword)) return false;
+		if (upperSQL.includes(keyword)) {
+			return false;
+		}
 	}
 
 	// Must start with SELECT or WITH (for CTEs)

apps/api/src/lib/website-utils.ts

@@ -143,7 +143,7 @@ export async function deriveWebsiteContext({ request }: { request: Request }) {
 		getCachedWebsite(website_id),
 		website_id && session?.user
 			? getTimezone(request, session)
-			: getTimezone(request, null)
+			: getTimezone(request, null),
 	]);
 
 	if (!website) {

apps/api/src/middleware/logging.ts

@@ -1 +0,0 @@
- 

apps/api/src/middleware/rate-limit.ts

@@ -1,6 +1,6 @@
 import { auth } from '@databuddy/auth';
-import { getRateLimitIdentifier, rateLimiters } from '@databuddy/rpc';
 import { cacheable } from '@databuddy/redis';
+import { getRateLimitIdentifier, rateLimiters } from '@databuddy/rpc';
 import { Elysia } from 'elysia';
 
 export interface RateLimitOptions {
@@ -39,7 +39,6 @@ export function createRateLimitMiddleware(options: RateLimitOptions) {
 		if (!options.skipAuth) {
 			const session = await getCachedAuthSession(request.headers);
 			userId = session?.user?.id;
-			
 		}
 
 		const identifier = getRateLimitIdentifier(userId, request.headers);

apps/api/src/query/utils.ts

@@ -192,7 +192,9 @@ function applyGeoNormalization(
 ): Record<string, any>[] {
 	return data.map((row) => {
 		// Only normalize if row has a 'name' field (country/region/etc)
-		if (!row.name) return row;
+		if (!row.name) {
+			return row;
+		}
 		const code = getCountryCode(row.name);
 		const name = getCountryName(code);
 		return {

apps/basket/src/hooks/auth.ts

@@ -15,6 +15,9 @@ type WebsiteWithOwner = Website & {
 	ownerId: string | null;
 };
 
+const REGEX_WWW_PREFIX = /^www\./;
+const REGEX_DOMAIN_LABEL = /^[a-zA-Z0-9-]+$/;
+
 /**
  * Resolves the owner's user ID for a given website.
  * The owner is the user if it's a personal project, or the organization's owner
@@ -161,7 +164,7 @@ export function normalizeDomain(domain: string): string {
 
 	try {
 		const hostname = new URL(urlString).hostname;
-		const finalDomain = hostname.replace(/^www\./, '');
+		const finalDomain = hostname.replace(REGEX_WWW_PREFIX, '');
 
 		if (!isValidDomainFormat(finalDomain)) {
 			throw new Error(
@@ -213,7 +216,7 @@ export function isValidDomainFormat(domain: string): boolean {
 			return false;
 		}
 		if (
-			!/^[a-zA-Z0-9-]+$/.test(label) ||
+			!REGEX_DOMAIN_LABEL.test(label) ||
 			label.startsWith('-') ||
 			label.endsWith('-')
 		) {

apps/basket/src/polyfills/compression.js

@@ -12,14 +12,15 @@ globalThis.CompressionStream ??= class CompressionStream {
 	writable;
 
 	constructor(format) {
-		make(
-			this,
-			format === 'deflate'
-				? zlib.createDeflate()
-				: format === 'gzip'
-					? zlib.createGzip()
-					: zlib.createDeflateRaw()
-		);
+		let handle;
+		if (format === 'deflate') {
+			handle = zlib.createDeflate();
+		} else if (format === 'gzip') {
+			handle = zlib.createGzip();
+		} else {
+			handle = zlib.createDeflateRaw();
+		}
+		make(this, handle);
 	}
 };
 
@@ -28,13 +29,14 @@ globalThis.DecompressionStream ??= class DecompressionStream {
 	writable;
 
 	constructor(format) {
-		make(
-			this,
-			format === 'deflate'
-				? zlib.createInflate()
-				: format === 'gzip'
-					? zlib.createGunzip()
-					: zlib.createInflateRaw()
-		);
+		let handle;
+		if (format === 'deflate') {
+			handle = zlib.createInflate();
+		} else if (format === 'gzip') {
+			handle = zlib.createGunzip();
+		} else {
+			handle = zlib.createInflateRaw();
+		}
+		make(this, handle);
 	}
 };

apps/basket/src/routes/basket.ts

@@ -447,7 +447,7 @@ async function checkDuplicate(
 async function logBlockedTraffic(
 	request: Request,
 	body: any,
-	query: any,
+	_query: any,
 	blockReason: string,
 	blockCategory: string,
 	botName?: string,