Skip to content

Commit 3e4d1a3

Browse files
committed
remove flipping SASL
1 parent dd10778 commit 3e4d1a3

File tree

6 files changed

+4
-25
lines changed

6 files changed

+4
-25
lines changed

apps/basket/src/lib/kafka.test.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,6 @@ describe('Kafka Producer and Consumer', () => {
2020
initialRetryTime: 100,
2121
retries: 8,
2222
},
23-
sasl: {
24-
mechanism: 'scram-sha-256',
25-
username: process.env.KAFKA_USER as string,
26-
password: process.env.KAFKA_PASSWORD as string,
27-
},
2823
});
2924

3025
producer = kafka.producer();

apps/basket/src/lib/producer.test.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,6 @@ describe('Producer Module', () => {
1616
kafka = new Kafka({
1717
clientId: 'producer-test',
1818
brokers: [KAFKA_BROKERS],
19-
sasl: {
20-
mechanism: 'scram-sha-256',
21-
username: process.env.KAFKA_USER as string,
22-
password: process.env.KAFKA_PASSWORD as string,
23-
},
2419
retry: {
2520
initialRetryTime: 100,
2621
retries: 8,

apps/basket/src/lib/producer.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -66,11 +66,6 @@ if (BROKER) {
6666
brokers: [BROKER],
6767
connectionTimeout: 5000,
6868
requestTimeout: KAFKA_TIMEOUT,
69-
sasl:{
70-
mechanism: 'scram-sha-256',
71-
username: process.env.KAFKA_USER as string,
72-
password: process.env.KAFKA_PASSWORD as string,
73-
}
7469
});
7570
producer = kafka.producer({
7671
allowAutoTopicCreation: true,

infra/env.example

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@ CLICKHOUSE_URL=http://clickhouse:8123
77
REDPANDA_LOG_LEVEL=info
88
REDPANDA_ADVERTISED_HOST=localhost
99
REDPANDA_BROKER=redpanda:9092
10-
VECTOR_KAFKA_USER=vector-agent
11-
VECTOR_KAFKA_PASSWORD=super_secret_password
1210

1311
# Vector Configuration
1412
VECTOR_LOG=info

infra/ingest/docker-compose.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -62,12 +62,12 @@ services:
6262
volumes:
6363
- ./vector.yaml:/etc/vector/vector.yaml:ro
6464
environment:
65-
CLICKHOUSE_USER: ${CLICKHOUSE_USER}
66-
CLICKHOUSE_PASSWORD: ${CLICKHOUSE_PASSWORD}
65+
CLICKHOUSE_USER: ${CLICKHOUSE_USER:-default}
66+
CLICKHOUSE_PASSWORD: ${CLICKHOUSE_PASSWORD:-defaultpass}
6767
CLICKHOUSE_URL: ${CLICKHOUSE_URL:-http://clickhouse:8123}
6868
VECTOR_LOG: ${VECTOR_LOG:-info}
69-
VECTOR_KAFKA_USER: ${VECTOR_KAFKA_USER}
70-
VECTOR_KAFKA_PASSWORD: ${VECTOR_KAFKA_PASSWORD}
69+
VECTOR_KAFKA_USER: ${VECTOR_KAFKA_USER:-vector-agent}
70+
VECTOR_KAFKA_PASSWORD: ${VECTOR_KAFKA_PASSWORD:-super_secret_password}
7171
REDPANDA_BROKER: ${REDPANDA_BROKER:-redpanda:9092}
7272
networks:
7373
- databuddy

infra/ingest/vector.yaml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,6 @@ sources:
22
redpanda:
33
type: kafka
44
bootstrap_servers: "${REDPANDA_BROKER}"
5-
sasl:
6-
mechanism: "scram-sha-256"
7-
username: "${VECTOR_KAFKA_USER}"
8-
password: "${VECTOR_KAFKA_PASSWORD}"
95
group_id: vector-analytics
106
topics:
117
- analytics-events

0 commit comments

Comments
 (0)