merge

Author: izadoesdev

.github/workflows/lint.yml

@@ -0,0 +1,46 @@
+# Linting Check for Pull Requests
+#
+# This workflow runs code quality checks on all pull requests to ensure
+# consistent code style and catch potential issues before they're merged.
+# It uses Biome for linting with the configuration from biome.jsonc.
+#
+name: Lint
+
+on:
+  pull_request:
+    branches: [ "main" ]
+  push:
+    branches: [ "main" ]
+  merge_group:
+    branches: [ "main" ]
+
+permissions:
+  contents: read
+  pull-requests: write
+
+jobs:
+  lint:
+    name: Lint Code
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v4
+
+      - name: Setup Bun
+        uses: oven-sh/setup-bun@v1
+        with:
+          bun-version: 1.2.19
+
+      - name: Cache dependencies
+        uses: actions/cache@v3
+        with:
+          path: ~/.bun/install/cache
+          key: ${{ runner.os }}-bun-${{ hashFiles('bun.lock') }}
+          restore-keys: |
+            ${{ runner.os }}-bun-
+
+      - name: Install dependencies
+        run: bun install
+
+      - name: Run lint check
+        run: bun run lint

apps/api/src/agent/core/response-processor.ts

@@ -1,8 +1,8 @@
+import type { StreamingUpdate } from '@databuddy/shared';
 import type { z } from 'zod';
 import { handleChartResponse } from '../handlers/chart-handler';
 import { handleMetricResponse } from '../handlers/metric-handler';
 import type { AIResponseJsonSchema } from '../prompts/agent';
-import type { StreamingUpdate } from '@databuddy/shared';
 import { generateThinkingSteps } from '../utils/stream-utils';
 import type { AssistantSession } from './assistant-session';
 

apps/api/src/lib/export/formatters.ts

@@ -5,7 +5,9 @@ import type { ExportFormat } from './types';
 export function convertToCSV<T extends Record<string, unknown>>(
 	data: T[]
 ): string {
-	if (data.length === 0) return '';
+	if (data.length === 0) {
+		return '';
+	}
 
 	const headers = Object.keys(data[0] || {}).join(',');
 	const rows = data
@@ -36,7 +38,9 @@ export function convertToCSV<T extends Record<string, unknown>>(
 export function convertToTXT<T extends Record<string, unknown>>(
 	data: T[]
 ): string {
-	if (data.length === 0) return '';
+	if (data.length === 0) {
+		return '';
+	}
 
 	const headers = Object.keys(data[0] || {}).join('\t');
 	const rows = data
@@ -60,7 +64,9 @@ export function convertToProto<T extends Record<string, unknown>>(
 	data: T[],
 	typeName: string
 ): string {
-	if (data.length === 0) return '';
+	if (data.length === 0) {
+		return '';
+	}
 
 	let protoContent = `# Protocol Buffer Text Format\n# Type: ${typeName}\n\n`;
 
@@ -110,7 +116,6 @@ export function formatData<T extends Record<string, unknown>>(
 			return convertToTXT(data);
 		case 'proto':
 			return convertToProto(data, typeName);
-		case 'json':
 		default:
 			return JSON.stringify(data, null, 2);
 	}
@@ -124,7 +129,6 @@ export function getFileExtension(format: ExportFormat): string {
 			return 'txt';
 		case 'proto':
 			return 'proto.txt';
-		case 'json':
 		default:
 			return 'json';
 	}

apps/api/src/routes/export.ts

@@ -11,7 +11,7 @@ import { createRateLimitMiddleware } from '../middleware/rate-limit';
 
 dayjs.extend(utc);
 
-const exportRateLimit = createRateLimitMiddleware({
+const _exportRateLimit = createRateLimitMiddleware({
 	type: 'expensive',
 	identifier: 'export',
 	customConfig: {

apps/basket/src/routes/basket.ts

@@ -314,8 +314,8 @@ async function insertWebVitals(
 async function insertCustomEvent(
 	customData: any,
 	clientId: string,
-	userAgent: string,
-	ip: string
+	_userAgent: string,
+	_ip: string
 ): Promise<void> {
 	let eventId = sanitizeString(
 		customData.eventId,
@@ -369,8 +369,8 @@ async function insertCustomEvent(
 async function insertOutgoingLink(
 	linkData: any,
 	clientId: string,
-	userAgent: string,
-	ip: string
+	_userAgent: string,
+	_ip: string
 ): Promise<void> {
 	let eventId = sanitizeString(
 		linkData.eventId,

apps/dashboard/app/(auth)/login/page.tsx

@@ -1,7 +1,14 @@
 'use client';
 
 import { signIn } from '@databuddy/auth/client';
-import { EyeIcon, EyeSlashIcon, GithubLogoIcon, SpinnerIcon, SparkleIcon, GoogleLogoIcon } from '@phosphor-icons/react';
+import {
+	EyeIcon,
+	EyeSlashIcon,
+	GithubLogoIcon,
+	GoogleLogoIcon,
+	SparkleIcon,
+	SpinnerIcon,
+} from '@phosphor-icons/react';
 import Link from 'next/link';
 import { useRouter } from 'next/navigation';
 import { Suspense, useEffect, useState } from 'react';
@@ -100,7 +107,7 @@ function LoginPage() {
 
 	return (
 		<>
-			<div className="mb-8 text-center -mt-8">
+			<div className="-mt-8 mb-8 text-center">
 				<h1 className="font-bold text-2xl text-foreground">Welcome back</h1>
 				<p className="mt-2 text-muted-foreground">
 					Sign in to your account to continue your journey with Databuddy
@@ -111,7 +118,7 @@ function LoginPage() {
 				<div className="-bottom-40 -left-40 pointer-events-none absolute h-80 w-80 rounded-full blur-3xl" />
 				<div className="relative z-10">
 					<div className="space-y-6">
-						<div className="grid grid-cols-1 gap-3 lg:grid-cols-2 -mt-2">
+						<div className="-mt-2 grid grid-cols-1 gap-3 sm:grid-cols-2">
 							<Button
 								className="relative flex h-11 w-full cursor-pointer items-center justify-center transition-all duration-200 hover:bg-primary/5"
 								disabled={isLoading}
@@ -122,7 +129,7 @@ function LoginPage() {
 								<GithubLogoIcon className="mr-2 h-5 w-5" />
 								<span>Sign in with GitHub</span>
 								{lastUsed === 'github' && (
-								<span className="absolute -top-4 -right-0.5 inline-flex items-center rounded-full border border-primary/20 bg-primary/10 px-1.5 py-0.5 font-medium text-primary text-xs">
+									<span className="-top-4 -right-0.5 absolute inline-flex items-center rounded-full border border-primary/20 bg-primary/10 px-1.5 py-0.5 font-medium text-primary text-xs">
 										Last used
 									</span>
 								)}
@@ -137,7 +144,7 @@ function LoginPage() {
 								<GoogleLogoIcon className="mr-2 h-5 w-5" />
 								<span>Sign in with Google</span>
 								{lastUsed === 'google' && (
-									<span className="absolute -top-4 -right-0.5 inline-flex items-center rounded-full border border-primary/20 bg-primary/10 px-1.5 py-0.5 font-medium text-primary text-xs">
+									<span className="-top-4 -right-0.5 absolute inline-flex items-center rounded-full border border-primary/20 bg-primary/10 px-1.5 py-0.5 font-medium text-primary text-xs">
 										Last used
 									</span>
 								)}
@@ -161,7 +168,7 @@ function LoginPage() {
 								<div className="relative">
 									<Input
 										autoComplete="email"
-										className="h-11 border-none text-foreground bg-input transition-all duration-200 focus:ring-2 focus:ring-primary/20 placeholder:text-muted-foreground/50"
+										className="h-11 border-none bg-input text-foreground transition-all duration-200 placeholder:text-muted-foreground/50 focus:ring-2 focus:ring-primary/20"
 										id="email"
 										name="email"
 										onChange={(e) => setEmail(e.target.value)}
@@ -197,7 +204,7 @@ function LoginPage() {
 								<div className="relative">
 									<Input
 										autoComplete="current-password"
-										className="h-11 pr-10 bg-input border-none transition-all duration-200 focus:ring-2 focus:ring-primary/20 placeholder:text-muted-foreground/50"
+										className="h-11 border-none bg-input pr-10 transition-all duration-200 placeholder:text-muted-foreground/50 focus:ring-2 focus:ring-primary/20"
 										id="password"
 										name="password"
 										onChange={(e) => setPassword(e.target.value)}
@@ -207,7 +214,9 @@ function LoginPage() {
 										value={password}
 									/>
 									<Button
-										aria-label={showPassword ? 'Hide password' : 'Show password'}
+										aria-label={
+											showPassword ? 'Hide password' : 'Show password'
+										}
 										className="absolute top-0 right-0 h-full px-3 text-muted-foreground hover:text-foreground"
 										onClick={() => setShowPassword(!showPassword)}
 										size="sm"

apps/dashboard/app/(main)/observability/layout.tsx

@@ -4,6 +4,8 @@ export default function ObservabilityLayout({
 	children: React.ReactNode;
 }) {
 	return (
-		<div className="mx-auto max-w-[1600px] space-y-6 p-4 sm:p-6 lg:p-8">{children}</div>
+		<div className="mx-auto max-w-[1600px] space-y-6 p-4 sm:p-6 lg:p-8">
+			{children}
+		</div>
 	);
-}
+}

apps/dashboard/app/(main)/revenue/_components/onboarding/steps/overview-step.tsx

@@ -11,9 +11,7 @@ export function OverviewStep({ onNext }: OverviewStepProps) {
 	return (
 		<div className="space-y-4">
 			<div className="rounded-lg border border-blue-200 bg-blue-50 p-4 dark:border-blue-800 dark:bg-blue-950/20">
-				<h3 className="mb-2 font-medium text-foreground">
-					What you'll get:
-				</h3>
+				<h3 className="mb-2 font-medium text-foreground">What you'll get:</h3>
 				<ul className="space-y-2 text-muted-foreground text-sm">
 					<li className="flex items-center gap-2">
 						<CheckCircleIcon

apps/dashboard/app/(main)/settings/_components/sessions-form.tsx

@@ -37,7 +37,7 @@ export function SessionsForm() {
 
 	useEffect(() => {
 		fetchSessions();
-	}, []);
+	}, [fetchSessions]);
 
 	const fetchSessions = async () => {
 		setIsLoading(true);
@@ -110,8 +110,9 @@ export function SessionsForm() {
 	};
 
 	const getDeviceIcon = (userAgent?: string | null) => {
-		if (!userAgent)
+		if (!userAgent) {
 			return <GlobeIcon className="h-4 w-4" size={16} weight="duotone" />;
+		}
 
 		const ua = userAgent.toLowerCase();
 		if (
@@ -126,7 +127,9 @@ export function SessionsForm() {
 	};
 
 	const formatUserAgent = (userAgent?: string | null) => {
-		if (!userAgent) return 'Unknown Device';
+		if (!userAgent) {
+			return 'Unknown Device';
+		}
 
 		// Extract browser and OS information
 		let browser = 'Unknown Browser';

apps/dashboard/app/(main)/websites/[id]/_components/tabs/audience-tab.tsx

@@ -192,7 +192,7 @@ export function WebsiteAudienceTab({
 	}, [isRefreshing, handleRefresh]);
 
 	const onAddFilter = useCallback(
-		(field: string, value: string, tableTitle?: string) => {
+		(field: string, value: string, _tableTitle?: string) => {
 			// The field parameter now contains the correct filter field from the tab configuration
 			const filter = {
 				field,