feat: better traces

Author: izadoesdev

apps/basket/src/lib/event-service.ts

@@ -58,7 +58,7 @@ export function insertError(
 
 		const { anonymizedIP, country, region } = geoData;
 		const { browserName, browserVersion, osName, osVersion, deviceType } =
-			parseUserAgent(userAgent);
+			await parseUserAgent(userAgent);
 
 		const errorEvent: ErrorEvent = {
 			id: randomUUID(),
@@ -140,7 +140,7 @@ export async function insertWebVitals(
 
 	const { country, region } = await getGeo(ip);
 	const { browserName, browserVersion, osName, osVersion, deviceType } =
-		parseUserAgent(userAgent);
+		await parseUserAgent(userAgent);
 
 	const webVitalsEvent: WebVitalsEvent = {
 		id: randomUUID(),
@@ -330,7 +330,7 @@ export function insertTrackEvent(
 			deviceType,
 			deviceBrand,
 			deviceModel,
-		} = parseUserAgent(userAgent);
+		} = await parseUserAgent(userAgent);
 		const now = Date.now();
 
 		const trackEvent: AnalyticsEvent = {

apps/basket/src/lib/request-validation.ts

@@ -199,27 +199,29 @@ export function checkForBot(
 	query: any,
 	clientId: string,
 	userAgent: string
-): { error?: { status: string } } | undefined {
-	const botCheck = detectBot(userAgent, request);
-	if (botCheck.isBot) {
-		logBlockedTraffic(
-			request,
-			body,
-			query,
-			botCheck.reason || "unknown_bot",
-			botCheck.category || "Bot Detection",
-			botCheck.botName,
-			clientId
-		);
-		setAttributes({
-			"validation.failed": true,
-			"validation.reason": "bot_detected",
-			"bot.name": botCheck.botName || "unknown",
-			"bot.category": botCheck.category || "Bot Detection",
-			"bot.detection_reason": botCheck.reason || "unknown_bot",
-		});
-		return { error: { status: "ignored" } };
-	}
-	return;
+): Promise<{ error?: { status: string } } | undefined> {
+	return record("checkForBot", () => {
+		const botCheck = detectBot(userAgent, request);
+		if (botCheck.isBot) {
+			logBlockedTraffic(
+				request,
+				body,
+				query,
+				botCheck.reason || "unknown_bot",
+				botCheck.category || "Bot Detection",
+				botCheck.botName,
+				clientId
+			);
+			setAttributes({
+				"validation.failed": true,
+				"validation.reason": "bot_detected",
+				"bot.name": botCheck.botName || "unknown",
+				"bot.category": botCheck.category || "Bot Detection",
+				"bot.detection_reason": botCheck.reason || "unknown_bot",
+			});
+			return { error: { status: "ignored" } };
+		}
+		return;
+	});
 }
 

apps/basket/src/lib/tracing.ts

@@ -63,11 +63,22 @@ function getTracer() {
 export function record<T>(name: string, fn: () => Promise<T> | T): Promise<T> {
 	const tracer = getTracer();
 	return tracer.startActiveSpan(name, async (span) => {
+		const startTime = Date.now();
 		try {
 			const result = await fn();
+			const duration = Date.now() - startTime;
+			span.setAttribute("operation.duration_ms", duration);
+
+			if (duration > 1000) {
+				span.setAttribute("operation.slow", true);
+				span.setAttribute("operation.duration_seconds", duration / 1000);
+			}
+
 			span.setStatus({ code: SpanStatusCode.OK });
 			return result;
 		} catch (error) {
+			const duration = Date.now() - startTime;
+			span.setAttribute("operation.duration_ms", duration);
 			span.setStatus({
 				code: SpanStatusCode.ERROR,
 				message: error instanceof Error ? error.message : String(error),
@@ -145,8 +156,15 @@ export function endRequestSpan(
 	statusCode: number,
 	startTime: number
 ): void {
+	const duration = Date.now() - startTime;
 	span.setAttribute("http.status_code", statusCode);
-	span.setAttribute("http.response.duration_ms", Date.now() - startTime);
+	span.setAttribute("http.response.duration_ms", duration);
+
+	if (duration > 500) {
+		span.setAttribute("http.slow", true);
+		span.setAttribute("http.duration_seconds", duration / 1000);
+	}
+
 	span.setStatus({
 		code: statusCode >= 400 ? SpanStatusCode.ERROR : SpanStatusCode.OK,
 		message: statusCode >= 400 ? `HTTP ${statusCode}` : undefined,