fix(databunny): getting null is not an object (evaluating 'context.user.role') in chat response (#79)

AyanavaKarmakar · web-flow · commit b1fa2607d352 · 2025-08-13T18:10:54.000+03:00
* fix(databunny): improve error handling and type safety in processor, chart, and metric handlers

* chore: format

* fix(chart-handler): ensure chartType is always defined in response
diff --git a/apps/api/src/agent/handlers/chart-handler.ts b/apps/api/src/agent/handlers/chart-handler.ts
@@ -1,11 +1,14 @@
+import type { User } from '@databuddy/auth';
+import type { Website } from '@databuddy/shared';
 import type { z } from 'zod';
 import type { AIResponseJsonSchema } from '../prompts/agent';
 import { executeQuery } from '../utils/query-executor';
 import { validateSQL } from '../utils/sql-validator';
 import type { StreamingUpdate } from '../utils/stream-utils';
 
-const getRandomMessage = (messages: string[]) =>
-	messages[Math.floor(Math.random() * messages.length)];
+const getRandomMessage = (messages: string[]): string =>
+	messages[Math.floor(Math.random() * messages.length)] ||
+	'An error occurred while processing your request.';
 
 const queryFailedMessages = [
 	'I ran into an issue getting that data. The information might not be available right now.',
@@ -20,8 +23,8 @@ const noDataMessages = [
 ];
 
 export interface ChartHandlerContext {
-	user: any;
-	website: any;
+	user?: User | null;
+	website: Website;
 	debugInfo: Record<string, unknown>;
 	startTime: number;
 	aiTime: number;
@@ -35,7 +38,7 @@ export async function* handleChartResponse(
 		yield {
 			type: 'error',
 			content: 'AI did not provide a query for the chart.',
-			debugInfo: context.user.role === 'ADMIN' ? context.debugInfo : undefined,
+			debugInfo: context.user?.role === 'ADMIN' ? context.debugInfo : undefined,
 		};
 		return;
 	}
@@ -44,7 +47,7 @@ export async function* handleChartResponse(
 		yield {
 			type: 'error',
 			content: 'Generated query failed security validation.',
-			debugInfo: context.user.role === 'ADMIN' ? context.debugInfo : undefined,
+			debugInfo: context.user?.role === 'ADMIN' ? context.debugInfo : undefined,
 		};
 		return;
 	}
@@ -53,7 +56,7 @@ export async function* handleChartResponse(
 		const queryResult = await executeQuery(parsedAiJson.sql);
 		const totalTime = Date.now() - context.startTime;
 
-		if (context.user.role === 'ADMIN') {
+		if (context.user?.role === 'ADMIN') {
 			context.debugInfo.processing = {
 				aiTime: context.aiTime,
 				queryTime: Date.now() - context.startTime - context.aiTime,
@@ -65,15 +68,15 @@ export async function* handleChartResponse(
 			type: 'complete',
 			content:
 				queryResult.data.length > 0
-					? `Found ${queryResult.data.length} data points. Displaying as a ${parsedAiJson.chart_type?.replace(/_/g, ' ') || 'chart'}.`
+					? `Found ${queryResult.data.length} data points. Displaying as a ${parsedAiJson.chart_type ? parsedAiJson.chart_type.replace(/_/g, ' ') : 'chart'}.`
 					: getRandomMessage(noDataMessages),
 			data: {
 				hasVisualization: queryResult.data.length > 0,
 				chartType: parsedAiJson.chart_type,
 				data: queryResult.data,
 				responseType: 'chart',
 			},
-			debugInfo: context.user.role === 'ADMIN' ? context.debugInfo : undefined,
+			debugInfo: context.user?.role === 'ADMIN' ? context.debugInfo : undefined,
 		};
 	} catch (queryError: unknown) {
 		console.error('❌ SQL execution error', {
@@ -83,7 +86,7 @@ export async function* handleChartResponse(
 		yield {
 			type: 'error',
 			content: getRandomMessage(queryFailedMessages),
-			debugInfo: context.user.role === 'ADMIN' ? context.debugInfo : undefined,
+			debugInfo: context.user?.role === 'ADMIN' ? context.debugInfo : undefined,
 		};
 	}
 }
diff --git a/apps/api/src/agent/handlers/metric-handler.ts b/apps/api/src/agent/handlers/metric-handler.ts
@@ -1,12 +1,14 @@
+import type { User } from '@databuddy/auth';
+import type { Website } from '@databuddy/shared';
 import type { z } from 'zod';
 import type { AIResponseJsonSchema } from '../prompts/agent';
 import { executeQuery } from '../utils/query-executor';
 import { validateSQL } from '../utils/sql-validator';
 import type { StreamingUpdate } from '../utils/stream-utils';
 
 export interface MetricHandlerContext {
-	user: any;
-	website: any;
+	user?: User | null;
+	website: Website;
 	debugInfo: Record<string, unknown>;
 }
 
@@ -20,7 +22,7 @@ export async function* handleMetricResponse(
 				type: 'error',
 				content: 'Generated query failed security validation.',
 				debugInfo:
-					context.user.role === 'ADMIN' ? context.debugInfo : undefined,
+					context.user?.role === 'ADMIN' ? context.debugInfo : undefined,
 			};
 			return;
 		}
@@ -86,6 +88,6 @@ async function* sendMetricResponse(
 			metricValue,
 			metricLabel: parsedAiJson.metric_label,
 		},
-		debugInfo: context.user.role === 'ADMIN' ? context.debugInfo : undefined,
+		debugInfo: context.user?.role === 'ADMIN' ? context.debugInfo : undefined,
 	};
 }
diff --git a/apps/api/src/agent/processor.ts b/apps/api/src/agent/processor.ts
@@ -9,8 +9,9 @@ import type { StreamingUpdate } from './utils/stream-utils';
 import { generateThinkingSteps } from './utils/stream-utils';
 
 // Simple message variation helpers
-const getRandomMessage = (messages: string[]) =>
-	messages[Math.floor(Math.random() * messages.length)];
+const getRandomMessage = (messages: string[]): string =>
+	messages[Math.floor(Math.random() * messages.length)] ||
+	'An error occurred while processing your request.';
 
 const parseErrorMessages = [
 	"I'm having trouble understanding that request. Could you try asking in a different way?",
@@ -38,7 +39,7 @@ export interface AssistantRequest {
 }
 
 export interface AssistantContext {
-	user: User;
+	user?: User | null;
 	website: Website;
 	debugInfo: Record<string, unknown>;
 }
@@ -56,7 +57,7 @@ export async function* processAssistantRequest(
 			website_hostname: request.website_hostname,
 		});
 
-		if (context.user.role === 'ADMIN') {
+		if (context.user?.role === 'ADMIN') {
 			context.debugInfo.validatedInput = {
 				message: request.message,
 				website_id: request.website_id,
@@ -70,7 +71,10 @@ export async function* processAssistantRequest(
 			request.website_id,
 			request.website_hostname,
 			'execute_chat',
-			request.context?.previousMessages,
+			request.context?.previousMessages?.map((msg) => ({
+				role: msg.role || 'user',
+				content: msg.content,
+			})),
 			undefined,
 			request.model
 		);
@@ -90,7 +94,7 @@ export async function* processAssistantRequest(
 				type: 'error',
 				content: getRandomMessage(parseErrorMessages),
 				debugInfo:
-					context.user.role === 'ADMIN'
+					context.user?.role === 'ADMIN'
 						? {
 								...context.debugInfo,
 								parseError: parsedResponse.error,
@@ -107,7 +111,7 @@ export async function* processAssistantRequest(
 				type: 'error',
 				content: getRandomMessage(parseErrorMessages),
 				debugInfo:
-					context.user.role === 'ADMIN' ? context.debugInfo : undefined,
+					context.user?.role === 'ADMIN' ? context.debugInfo : undefined,
 			};
 			return;
 		}
@@ -131,7 +135,7 @@ export async function* processAssistantRequest(
 						aiJson.text_response || "Here's the answer to your question.",
 					data: { hasVisualization: false, responseType: 'text' },
 					debugInfo:
-						context.user.role === 'ADMIN' ? context.debugInfo : undefined,
+						context.user?.role === 'ADMIN' ? context.debugInfo : undefined,
 				};
 				break;
 
@@ -151,7 +155,7 @@ export async function* processAssistantRequest(
 						type: 'error',
 						content: 'Invalid chart configuration.',
 						debugInfo:
-							context.user.role === 'ADMIN' ? context.debugInfo : undefined,
+							context.user?.role === 'ADMIN' ? context.debugInfo : undefined,
 					};
 				}
 				break;
@@ -161,7 +165,7 @@ export async function* processAssistantRequest(
 					type: 'error',
 					content: 'Invalid response format from AI.',
 					debugInfo:
-						context.user.role === 'ADMIN' ? context.debugInfo : undefined,
+						context.user?.role === 'ADMIN' ? context.debugInfo : undefined,
 				};
 		}
 	} catch (error: unknown) {
@@ -175,7 +179,7 @@ export async function* processAssistantRequest(
 			type: 'error',
 			content: getRandomMessage(unexpectedErrorMessages),
 			debugInfo:
-				context.user.role === 'ADMIN' ? { error: errorMessage } : undefined,
+				context.user?.role === 'ADMIN' ? { error: errorMessage } : undefined,
 		};
 	}
 }
diff --git a/apps/api/src/routes/assistant.ts b/apps/api/src/routes/assistant.ts
@@ -53,7 +53,7 @@ export const assistant = new Elysia({ prefix: '/v1/assistant' })
 				};
 
 				const assistantContext: AssistantContext = {
-					user: (user ?? null) as unknown as AssistantContext['user'],
+					user: user ?? null,
 					website,
 					debugInfo: {},
 				};
diff --git a/apps/dashboard/app/(main)/websites/[id]/_components/utils/add-filters.tsx b/apps/dashboard/app/(main)/websites/[id]/_components/utils/add-filters.tsx
@@ -1,9 +1,9 @@
 'use client';
 
-import { Suspense, useCallback, useState } from 'react';
-import { useParams } from 'next/navigation';
+import { type DynamicQueryFilter, filterOptions } from '@databuddy/shared';
 import { FunnelIcon } from '@phosphor-icons/react';
-import { filterOptions, type DynamicQueryFilter } from '@databuddy/shared';
+import { useParams } from 'next/navigation';
+import { Suspense, useCallback, useState } from 'react';
 import { Button } from '@/components/ui/button';
 import {
 	Command,
@@ -31,12 +31,12 @@ import {
 	SelectTrigger,
 	SelectValue,
 } from '@/components/ui/select';
+import { Skeleton } from '@/components/ui/skeleton';
+import { operatorOptions } from '@/hooks/use-filters';
 import {
 	type AutocompleteData,
 	useAutocompleteData,
 } from '@/hooks/use-funnels';
-import { operatorOptions } from '@/hooks/use-filters';
-import { Skeleton } from '@/components/ui/skeleton';
 
 type OperatorOption = (typeof operatorOptions)[number];
 type FilterOption = (typeof filterOptions)[number];
@@ -256,7 +256,7 @@ function FilterForm({
 			<div className="flex flex-col gap-2">
 				{Array.from({ length: Math.min(numberOfFilters, 5) }).map(
 					(_, index) => (
-						<Skeleton key={`filter-skeleton-${index}`} className="h-8 w-full" />
+						<Skeleton className="h-8 w-full" key={`filter-skeleton-${index}`} />
 					)
 				)}
 			</div>
diff --git a/apps/dashboard/app/(main)/websites/[id]/_components/utils/types.ts b/apps/dashboard/app/(main)/websites/[id]/_components/utils/types.ts
@@ -1,4 +1,8 @@
-import type { DateRange as BaseDateRange, DynamicQueryFilter, Website } from '@databuddy/shared';
+import type {
+	DateRange as BaseDateRange,
+	DynamicQueryFilter,
+	Website,
+} from '@databuddy/shared';
 
 // Extended date range with granularity
 export interface DateRange extends BaseDateRange {
diff --git a/apps/dashboard/app/(main)/websites/[id]/assistant/components/visualization-section.tsx b/apps/dashboard/app/(main)/websites/[id]/assistant/components/visualization-section.tsx
@@ -5,6 +5,7 @@ import {
 	ChartLineIcon,
 	ChartPieIcon,
 	CompassIcon,
+	DatabaseIcon,
 	DotsThreeOutlineVerticalIcon,
 	FunnelIcon,
 	GaugeIcon,
diff --git a/apps/dashboard/app/(main)/websites/[id]/funnels/_components/edit-funnel-dialog.tsx b/apps/dashboard/app/(main)/websites/[id]/funnels/_components/edit-funnel-dialog.tsx
@@ -1,12 +1,12 @@
 'use client';
 
+import { filterOptions } from '@databuddy/shared';
 import {
 	DragDropContext,
 	Draggable,
 	Droppable,
 	type DropResult,
 } from '@hello-pangea/dnd';
-import { filterOptions } from '@databuddy/shared';
 import {
 	ChartBarIcon,
 	FunnelIcon,
@@ -32,14 +32,14 @@ import {
 	SheetHeader,
 	SheetTitle,
 } from '@/components/ui/sheet';
+import { operatorOptions, useFilters } from '@/hooks/use-filters';
 import type {
 	AutocompleteData,
 	CreateFunnelData,
 	Funnel,
 	FunnelFilter,
 	FunnelStep,
 } from '@/hooks/use-funnels';
-import { operatorOptions, useFilters } from '@/hooks/use-filters';
 import { AutocompleteInput, DraggableStep } from './funnel-components';
 
 const defaultFilter: FunnelFilter = {
diff --git a/apps/dashboard/app/(main)/websites/[id]/goals/_components/edit-goal-dialog.tsx b/apps/dashboard/app/(main)/websites/[id]/goals/_components/edit-goal-dialog.tsx
@@ -27,9 +27,9 @@ import {
 	SheetHeader,
 	SheetTitle,
 } from '@/components/ui/sheet';
+import { operatorOptions, useFilters } from '@/hooks/use-filters';
 import type { AutocompleteData } from '@/hooks/use-funnels';
 import type { CreateGoalData, Goal } from '@/hooks/use-goals';
-import { operatorOptions, useFilters } from '@/hooks/use-filters';
 import { AutocompleteInput } from '../../funnels/_components/funnel-components';
 
 const defaultFilter: GoalFilter = {
