Skip to content

Commit b3729e3

Browse files
izadoesdevizadoesdev
committed
fix: remove console times
1 parent 584a1c7 commit b3729e3

File tree

5 files changed

+0
-46
lines changed

5 files changed

+0
-46
lines changed

‎apps/basket/src/hooks/auth.ts‎

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,7 @@ const REGEX_DOMAIN_LABEL = /^[a-zA-Z0-9-]+$/;
2727
* @returns A promise that resolves to the owner's user ID or null if not found.
2828
*/
2929
async function _resolveOwnerId(website: Website): Promise<string | null> {
30-
console.time("_resolveOwnerId");
3130
if (website.userId) {
32-
console.timeEnd("_resolveOwnerId");
3331
return website.userId;
3432
}
3533

@@ -46,7 +44,6 @@ async function _resolveOwnerId(website: Website): Promise<string | null> {
4644
});
4745

4846
if (orgMember) {
49-
console.timeEnd("_resolveOwnerId");
5047
return orgMember.userId;
5148
}
5249

@@ -70,7 +67,6 @@ async function _resolveOwnerId(website: Website): Promise<string | null> {
7067
{ websiteId: website.id },
7168
"No owner could be determined for website"
7269
);
73-
console.timeEnd("_resolveOwnerId");
7470
return null;
7571
}
7672

@@ -359,14 +355,12 @@ export function getWebsiteByIdV2(
359355
id: string
360356
): Promise<WebsiteWithOwner | null> {
361357
return record("getWebsiteByIdV2", async () => {
362-
console.time("getWebsiteByIdV2");
363358
setAttributes({
364359
"website.id": id,
365360
});
366361

367362
try {
368363
const result = await getWebsiteByIdWithOwnerCached(id);
369-
console.timeEnd("getWebsiteByIdV2");
370364

371365
if (result) {
372366
setAttributes({
@@ -386,7 +380,6 @@ export function getWebsiteByIdV2(
386380
setAttributes({
387381
"website.lookup_failed": true,
388382
});
389-
console.timeEnd("getWebsiteByIdV2");
390383
return null;
391384
}
392385
});

‎apps/basket/src/lib/event-service.ts‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -298,7 +298,6 @@ export function insertTrackEvent(
298298
ip: string
299299
): Promise<void> {
300300
return record("insertTrackEvent", async () => {
301-
console.time("insertTrackEvent");
302301
let eventId = sanitizeString(
303302
trackData.eventId,
304303
VALIDATION_LIMITS.SHORT_STRING_MAX_LENGTH
@@ -323,7 +322,6 @@ export function insertTrackEvent(
323322

324323
if (isDuplicate) {
325324
setAttributes({ "event.duplicate": true });
326-
console.timeEnd("insertTrackEvent");
327325
return;
328326
}
329327

@@ -432,13 +430,11 @@ export function insertTrackEvent(
432430

433431
try {
434432
sendEvent("analytics-events", trackEvent);
435-
console.timeEnd("insertTrackEvent");
436433
} catch (error) {
437434
logger.error(
438435
{ error, eventId },
439436
"Failed to queue track event"
440437
);
441-
console.timeEnd("insertTrackEvent");
442438
}
443439
});
444440
}

‎apps/basket/src/lib/request-validation.ts‎

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -26,13 +26,11 @@ type ValidationError = {
2626

2727
const checkAutumnCached = cacheable(
2828
async (ownerId: string) => {
29-
console.time("autumnCheck");
3029
const result = await autumn.check({
3130
customer_id: ownerId,
3231
feature_id: "events",
3332
send_event: true,
3433
});
35-
console.timeEnd("autumnCheck");
3634
return result.data;
3735
},
3836
{
@@ -52,7 +50,6 @@ export function validateRequest(
5250
request: Request
5351
): Promise<ValidationResult | ValidationError> {
5452
return record("validateRequest", async () => {
55-
console.time("validateRequest");
5653
if (!validatePayloadSize(body, VALIDATION_LIMITS.PAYLOAD_MAX_SIZE)) {
5754
logBlockedTraffic(
5855
request,
@@ -65,7 +62,6 @@ export function validateRequest(
6562
"validation.failed": true,
6663
"validation.reason": "payload_too_large",
6764
});
68-
console.timeEnd("validateRequest");
6965
return { error: { status: "error", message: "Payload too large" } };
7066
}
7167

@@ -85,7 +81,6 @@ export function validateRequest(
8581
"validation.failed": true,
8682
"validation.reason": "missing_client_id",
8783
});
88-
console.timeEnd("validateRequest");
8984
return { error: { status: "error", message: "Missing client ID" } };
9085
}
9186

@@ -109,7 +104,6 @@ export function validateRequest(
109104
"validation.reason": "invalid_client_id",
110105
"website.status": website?.status || "not_found",
111106
});
112-
console.timeEnd("validateRequest");
113107
return {
114108
error: { status: "error", message: "Invalid or inactive client ID" },
115109
};
@@ -139,7 +133,6 @@ export function validateRequest(
139133
"validation.reason": "exceeded_event_limit",
140134
"autumn.allowed": false,
141135
});
142-
console.timeEnd("validateRequest");
143136
return {
144137
error: { status: "error", message: "Exceeded event limit" },
145138
};
@@ -173,7 +166,6 @@ export function validateRequest(
173166
"validation.reason": "origin_not_authorized",
174167
"request.origin": origin,
175168
});
176-
console.timeEnd("validateRequest");
177169
return { error: { status: "error", message: "Origin not authorized" } };
178170
}
179171

@@ -191,7 +183,6 @@ export function validateRequest(
191183
"request.has_ip": Boolean(ip),
192184
});
193185

194-
console.timeEnd("validateRequest");
195186
return {
196187
success: true,
197188
clientId,

‎apps/basket/src/lib/security.ts‎

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,10 @@ function getCurrentDay(): number {
1212

1313
export const getDailySalt = cacheable(
1414
async (): Promise<string> => {
15-
console.time("getDailySalt");
1615
const saltKey = `salt:${getCurrentDay()}`;
1716
try {
1817
const salt = await redis.get(saltKey);
1918
if (salt) {
20-
console.timeEnd("getDailySalt");
2119
return salt;
2220
}
2321

@@ -26,11 +24,9 @@ export const getDailySalt = cacheable(
2624
redis.setex(saltKey, SALT_TTL, newSalt).catch((error) => {
2725
logger.error({ error }, "Failed to set daily salt in Redis");
2826
});
29-
console.timeEnd("getDailySalt");
3027
return newSalt;
3128
} catch (error) {
3229
logger.error({ error }, "Failed to get daily salt from Redis");
33-
console.timeEnd("getDailySalt");
3430
return crypto.randomBytes(32).toString("hex");
3531
}
3632
},
@@ -55,17 +51,14 @@ export async function checkDuplicate(
5551
eventId: string,
5652
eventType: string
5753
): Promise<boolean> {
58-
console.time("checkDuplicate");
5954
const key = `dedup:${eventType}:${eventId}`;
6055
const ttl = eventId.startsWith("exit_") ? EXIT_EVENT_TTL : STANDARD_EVENT_TTL;
6156

6257
try {
6358
const result = await redis.set(key, "1", "EX", ttl, "NX");
64-
console.timeEnd("checkDuplicate");
6559
return result === null;
6660
} catch (error) {
6761
logger.error({ error, eventId, eventType }, "Failed to check duplicate event in Redis");
68-
console.timeEnd("checkDuplicate");
6962
return false;
7063
}
7164
}

‎apps/basket/src/routes/basket.ts‎

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -296,12 +296,10 @@ const app = new Elysia()
296296
request: Request;
297297
};
298298

299-
console.time("total-request");
300299
try {
301300
const validation = await validateRequest(body, query, request);
302301

303302
if ("error" in validation) {
304-
console.timeEnd("total-request");
305303
return validation.error;
306304
}
307305

@@ -315,23 +313,19 @@ const app = new Elysia()
315313
]);
316314

317315
if (botError) {
318-
console.timeEnd("total-request");
319316
return botError.error;
320317
}
321318

322319
if (!parseResult.success) {
323-
console.timeEnd("total-request");
324320
return createSchemaErrorResponse(parseResult.error.issues);
325321
}
326322

327323
insertTrackEvent(body, clientId, userAgent, ip);
328-
console.timeEnd("total-request");
329324
return { status: "success", type: "track" };
330325
}
331326

332327
if (eventType === "error") {
333328
if (FILTERED_ERROR_MESSAGES.has(body.payload?.message)) {
334-
console.timeEnd("total-request");
335329
return {
336330
status: "ignored",
337331
type: "error",
@@ -345,17 +339,14 @@ const app = new Elysia()
345339
]);
346340

347341
if (botError) {
348-
console.timeEnd("total-request");
349342
return botError.error;
350343
}
351344

352345
if (!parseResult.success) {
353-
console.timeEnd("total-request");
354346
return createSchemaErrorResponse(parseResult.error.issues);
355347
}
356348

357349
insertError(body, clientId, userAgent, ip);
358-
console.timeEnd("total-request");
359350
return { status: "success", type: "error" };
360351
}
361352

@@ -366,17 +357,14 @@ const app = new Elysia()
366357
]);
367358

368359
if (botError) {
369-
console.timeEnd("total-request");
370360
return botError.error;
371361
}
372362

373363
if (!parseResult.success) {
374-
console.timeEnd("total-request");
375364
return createSchemaErrorResponse(parseResult.error.issues);
376365
}
377366

378367
insertWebVitals(body, clientId, userAgent, ip);
379-
console.timeEnd("total-request");
380368
return { status: "success", type: "web_vitals" };
381369
}
382370

@@ -390,15 +378,13 @@ const app = new Elysia()
390378
);
391379

392380
if (!parseResult.success) {
393-
console.timeEnd("total-request");
394381
return createSchemaErrorResponse(parseResult.error.issues);
395382
}
396383

397384
const eventId = body.eventId || randomUUID();
398385
const customEventWithId = { ...body, eventId };
399386

400387
await insertCustomEvent(customEventWithId, clientId, userAgent, ip);
401-
console.timeEnd("total-request");
402388
return { status: "success", type: "custom", eventId };
403389
}
404390

@@ -409,25 +395,20 @@ const app = new Elysia()
409395
]);
410396

411397
if (botError) {
412-
console.timeEnd("total-request");
413398
return botError.error;
414399
}
415400

416401
if (!parseResult.success) {
417-
console.timeEnd("total-request");
418402
return createSchemaErrorResponse(parseResult.error.issues);
419403
}
420404

421405
insertOutgoingLink(body, clientId, userAgent, ip);
422-
console.timeEnd("total-request");
423406
return { status: "success", type: "outgoing_link" };
424407
}
425408

426-
console.timeEnd("total-request");
427409
return { status: "error", message: "Unknown event type" };
428410
} catch (error) {
429411
logger.error({ error }, "Error processing event");
430-
console.timeEnd("total-request");
431412
return { status: "error", message: "Internal server error" };
432413
}
433414
})

0 commit comments

Comments
 (0)